Added plugin-related functions to the Java client#1979
Added plugin-related functions to the Java client#1979moritzvieli wants to merge 13 commits intoOpenLightingProject:masterfrom
Conversation
- Add OlaClient.reloadPlugins() - Add OlaClient.getPluginState() - Add OlaClient.setPluginState() - Changed evaluation of PROTOBUF_VERSION, because pkg-config adds trailing ".0" to the version, which is not compatible with the available Java dependencies
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
Thanks @moritzvieli .
I don't know whether you want to split this in two, as apart from some minor styling, the client changes are ready to go, whereas the Protobuf Java versioning may need a bit more testing and thought.
It would also be good to add some tests too please:
https://github.com/OpenLightingProject/ola/blob/master/java/src/test/java/ola/OlaClientTest.java
| <source>1.6</source> | ||
| <target>1.6</target> | ||
| <source>1.7</source> | ||
| <target>1.7</target> |
There was a problem hiding this comment.
Is this just because 1.6 is out of support?
There was a problem hiding this comment.
Yes. I was unable to compile this Java version with my locally installed Java version 21. 1.7 is still outdated, but a little bit less worse imo.
Co-authored-by: Peter Newman <[email protected]>
Co-authored-by: Peter Newman <[email protected]>
Co-authored-by: Peter Newman <[email protected]>
Co-authored-by: Peter Newman <[email protected]>
|
@peternewman I incorporated all changes. The conversation about the Java source version is not yet resolved. Please let me know, if I missed something. Thanks a lot! |
2 participants
The last change needs to be checked carefully. I tried building it on a Mac and it failed with the pkg-config version, because of the trailing ".0". Using "protoc --version" works, but might introduce other issues.