Skip to content

Problems with windows and LIBNAMEPREFIX #4528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattip opened this issue Feb 26, 2024 · 2 comments · Fixed by #4534
Closed

Problems with windows and LIBNAMEPREFIX #4528

mattip opened this issue Feb 26, 2024 · 2 comments · Fixed by #4534

Comments

@mattip
Copy link
Contributor

mattip commented Feb 26, 2024

#4485 went a long way to adding a prefix and suffix to the lib name, and allowing FIXED_LIBNAME=1, thanks.

But ... there is a difference between windows and posix. I used HEAD in MacPython/openblas-libs#141. On non-windows, I need to define both SYMBOLPREFIX=scipy_ and LIBNAMEPREFIX=scipy_ (and correspondingly, SYMBOLSUFFIX=64_ and LIBNAMESUFFIX=64_ when using INTERFACE64=1). But on windows, I must only define SYMBOLPREFIX=scipy_. Defining LIBNAMEPREFIX=scipy_ as well results in libscipy_scipy_openblas...

I currently worked around this since the CI runs are separate, but I wonder if this is intentional? The "offending" uses are in Makefile.system.

@martin-frbg
Copy link
Collaborator

Thought I had tracked down all sources of stuttering... will try to fix this tomorrow.

@martin-frbg
Copy link
Collaborator

Hmm. Actually it should be the same on non-Windows systems with the current solution - or are you building with gmake in one case and cmake in the other ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants