Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looping as a datapack occurs directly after the last note is played #455

Open
scutoel opened this issue May 19, 2024 · 2 comments
Open

Looping as a datapack occurs directly after the last note is played #455

scutoel opened this issue May 19, 2024 · 2 comments
Labels
C: Bug Something isn't working

Comments

@scutoel
Copy link

scutoel commented May 19, 2024

Describe the bug
When exporting as a datapack it will start the loop immediately after the last note is played and doesn't have the correct buffer.

To Reproduce
Steps to reproduce the behavior:

  1. Create simple looping song. Create a silent note to loop more closely
    image
  2. Export as datapack
  3. Play the datapack in game. In this example 2 ticks will be skipped.
  4. A work around for this to have the last set the nbs scoreboard to -(speed*2), -80 for 10ticks per second. A better solution would be to have the buffer on the last note and not the beginning of the first note. But its more work to do manually.

Expected behavior
Notes should not occur 1tick after the last is played when looping. It should keep the same rhythm and have the blank space after the last note

@Bentroen
Copy link
Member

Hi! Thanks for reporting the issue. Do you mind attaching the data pack you used so we can replicate this more easily?

@Bentroen Bentroen added the C: Bug Something isn't working label May 19, 2024
@scutoel
Copy link
Author

scutoel commented May 19, 2024

test.zip
test_double.zip
It is easier to hear with the double

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants