Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI Keyboard does not change attributes of played notes #474

Open
CreeperPookie opened this issue Sep 2, 2024 · 0 comments
Open

MIDI Keyboard does not change attributes of played notes #474

CreeperPookie opened this issue Sep 2, 2024 · 0 comments
Labels
C: Enhancement New feature or request
Milestone

Comments

@CreeperPookie
Copy link

CreeperPookie commented Sep 2, 2024

Describe the bug
When I got a MIDI keyboard for OpenNBS songs, I didn't expect many features to work (because OpenNBS isn't a full DAW like FL Studio or similar); however, it worked better than I thought; even the pressure sensitivity worked perfectly! however, one thing I did notice was the pitch wheel, modulation wheel, and volume slider did not change the sound of played notes at all; I wouldn't expect modulation to work since OpenNBS doesn't have any modulation options, but I was surprised that the pitch wheel didn't respond since there is a class dedicated to it scripts/midi_input_pitch_wheel/midi_input_pitch_wheel.gml

To Reproduce
Steps to reproduce the behavior:

  1. Open OpenNBS
  2. Connect a MIDI device with a pitch wheel or a volume slider
  3. Play a note with the MIDI device for reference
  4. Change the pitch or volume on the MIDI device
  5. Play the same note again
  6. Note how the newly configured pitch or volume doesn't affect the sound of the played note

Expected behavior
Ideally, I would expect OpenNBS to play the note with the current pitch and/or volume; however since OpenNBS seems to use an external library to read the pitch of MIDI devices, I understand this might not be practical to implement; I am curious though if certain MIDI keyboards do change the played pitch, especially if they output in the expected range.

Additional context
I did test the keyboard with a MIDI diagnostic program and it does receive the volume and pitch change events, but I did notice mine seems to output pitch from [0-16383] in steps of about 192; not to mention the code appears to be expecting a value from 0-127, which would explain this.
However, I did also observe the modulation wheel does output from [0-127] (this time in steps of 2 or 3), which is also very interesting
For context, I'm using a Midiplus AKM320

@CreeperPookie CreeperPookie changed the title MIDI Keyboard does not change attributes of played noted MIDI Keyboard does not change attributes of played notes Sep 2, 2024
@Bentroen Bentroen added the C: Enhancement New feature or request label Oct 6, 2024
@Bentroen Bentroen added this to the v4.0 milestone Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants