Skip to content

Selecting a layer which is already selected should deselect it #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bentroen opened this issue Sep 7, 2024 · 1 comment
Closed

Selecting a layer which is already selected should deselect it #476

Bentroen opened this issue Sep 7, 2024 · 1 comment
Labels
C: Enhancement New feature or request S: Resolved in next release This bugfix or suggestion has been applied to the code
Milestone

Comments

@Bentroen
Copy link
Member

Bentroen commented Sep 7, 2024

By @OverlordVizeon on Discord:

Suggestion: If the layer you wish to select is already selected, it should deselect it

Considerations:

  • Right now the program doesn't keep track of which layers have been selected, as selections operate purely at note block level. As such, we can't detect if a layer is entirely selected without checking all notes in the layer.
  • One way around it would be checking only the first (leftmost) note block in the layer and using it to determine if the layer is selected. This would 'work' for most purposes but would lead to a bit of inconsistent behavior.
  • Alternatively, shift-clicking the 'Select all blocks in this layer' button could be used as a shortcut to deselect the layer, regardless of its current selection status. Though this is a bit more cumbersome in terms of UX than a simple toggle.

Relates to: #464

@Bentroen Bentroen added the C: Enhancement New feature or request label Sep 7, 2024
@OctoFlareDev
Copy link
Collaborator

I think right clicking the select layer button to deselect would be a good way to go, since it's also the way to deselect individual notes

@Bentroen Bentroen added the S: Resolved in next release This bugfix or suggestion has been applied to the code label Dec 4, 2024
@Bentroen Bentroen added this to the v3.11 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Enhancement New feature or request S: Resolved in next release This bugfix or suggestion has been applied to the code
Projects
None yet
Development

No branches or pull requests

2 participants