Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes can appear incorrectly when in drop mode #498

Open
CreeperPookie opened this issue Dec 20, 2024 · 0 comments
Open

Notes can appear incorrectly when in drop mode #498

CreeperPookie opened this issue Dec 20, 2024 · 0 comments
Labels
C: Bug Something isn't working
Milestone

Comments

@CreeperPookie
Copy link

CreeperPookie commented Dec 20, 2024

Describe the bug
I've noticed something very odd about certain pitched notes when playing in drop mode; even though they play perfectly fine, there seems to be a gap around the C and F notes, most noticeable when playing a note pitch sweep. Even though I would expect some gap between notes between B/C and E/F. (Because of the piano layout) It's still a lot more than I would expect it to show, and it doesn't feel like an wrong pitch note in the song.

To Reproduce
Steps to reproduce the behavior:

  1. Find a song* with a progression of notes
  2. Open the song in NBS in player mode and enable drop mode
  3. Play the song and find a section with a note progression around C and F
  4. Notice how some notes will have gaps

*: Note: I realize there are probably a lot of songs that won't display wrong like this (especially if they have note progressions between C and F, are more velocity-based, or have the right spacing to not display this way), so I will attach a NBS file that does show this bug from one of the songs I've made

Expected behavior
This is a little tricky to explain since pianos have a much larger semitone gap between B/C and E/F. However, I would expect NBS to reduce the gap and potentially place the notes in the "average" position for those notes.

Screenshots
This is a note progression from one of my songs that shows what I mean:
image

for reference, this is the actual sequence of notes in the song, starting from the same point (G#7 is cut off in the first image):
image

Additional context
The main reason I think this is a bug instead of just a pitch issue in my song is that the pitch of the notes displayed incorrectly doesn't line up with the actual pitch of the notes in the song. For example, in my song, we start with a B6 w/ 32 cents, which does look fairly accurate for its pitch. However directly after is a C7 w/ -40 cents, which feels way too far from a base C7. and when going to the noted example, we move a C7 w/ -12 cents to a C7 w/ 16 cents; although that is barely a difference pitch-wise, visually it looks almost a semitone apart; that would be a huge difference if that was the actual pitch!.
Although I can't confirm this, it feels a lot like NBS could be treating these notes as if there were a literal B# key (not C) and placing the notes relative to that key; once it passes C, maybe it could effectively reset it and render it correctly (and of course again for E/F, too).
Here is my direct note progression download that I used as an example, but I think this may also show in a lot of other songs too.

@CreeperPookie CreeperPookie changed the title Pitched notes around C and F look incorrectly placed in drop mode Pitched notes around C and F appear incorrectly placed in drop mode Dec 20, 2024
@CreeperPookie CreeperPookie changed the title Pitched notes around C and F appear incorrectly placed in drop mode Notes can appear incorrectly when in drop mode Mar 6, 2025
@Bentroen Bentroen added the C: Bug Something isn't working label Mar 6, 2025
@Bentroen Bentroen added this to the v3.x milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants