Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewinding/fast forwarding can render playback incorrectly #502

Open
CreeperPookie opened this issue Jan 11, 2025 · 0 comments
Open

Rewinding/fast forwarding can render playback incorrectly #502

CreeperPookie opened this issue Jan 11, 2025 · 0 comments
Labels
C: Bug Something isn't working
Milestone

Comments

@CreeperPookie
Copy link

Describe the bug
I recently discovered the frame-by-frame playback mode, and now I don't know how I lived with page-by-page before lol; however, something I noticed is that when rewinding/fast forwarding with playback paused it displays the marker as tick-by-tick instead of by frame, which is not nearly as smooth (even for songs with a high BPM/tickrate)

To Reproduce
Steps to reproduce the behavior:

  1. Open NBS (no pun intended)

  2. Go to the playback settings within NBS preferences and change the marker mode to Frame by frame, and save the settings

  3. Create or open a song with at least one note at the end of the visible layer field (such that the play bar would have to scroll against the note field when it reaches it, like the below image)
    image

  4. Starting from tick 0, without playing the song fast forward playback until the last note is forced to scroll into view and observe the abrupt smoothness change

  5. Optionally, rewind the song directly after (again without playing the song), and observe how the song instantly snaps back to smooth when tick 0 scrolls back into view

Expected behavior
Assuming the user has the frame-by-frame mode enabled, I would expect NBS to move the play bar smoothly regardless of whether the song is playing. However, given how deep the rendering code can go, I understand that actually accomplishing that might not be easy.

@OctoFlareDev OctoFlareDev added the C: Bug Something isn't working label Mar 4, 2025
@Bentroen Bentroen added this to the v3.x milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants