Skip to content

Commit 4307696

Browse files
committed
[REF] refactor code
1 parent 3600d7e commit 4307696

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

spp_api/controllers/api.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#################################################################
3636

3737
API_ENDPOINT = "/api"
38-
SENSITIVE_KEYS = ["Authorization", "Cookie", "X-Api-Key", "X-Odoo-Session-Id"]
38+
SENSITIVE_KEYS = {"authorization", "cookie", "x-api-key", "x-odoo-session-id"}
3939

4040

4141
def create_api_log(func):
@@ -56,7 +56,11 @@ def wrapper(self, *args, **kwargs):
5656

5757
namespace_id = False
5858
if namespace:
59-
namespace_id = request.env["spp_api.namespace"].search([("name", "=", namespace)])
59+
version = kwargs.get("version")
60+
search_domain = [("name", "=", namespace)]
61+
if version:
62+
search_domain.append(("version_name", "=", version))
63+
namespace_id = request.env["spp_api.namespace"].search(search_domain, limit=1)
6064

6165
initial_val = {
6266
"method": path.method,
@@ -85,12 +89,10 @@ def wrapper(self, *args, **kwargs):
8589
request_log_val["request_data"] = request_data
8690

8791
# Sanitize headers
88-
safe_headers = {}
89-
for key, value in request.httprequest.headers.items():
90-
if key in SENSITIVE_KEYS:
91-
safe_headers[key] = "REDACTED"
92-
else:
93-
safe_headers[key] = value
92+
safe_headers = {
93+
key: "REDACTED" if key.lower() in SENSITIVE_KEYS else value
94+
for key, value in request.httprequest.headers.items()
95+
}
9496
request_log_val["headers"] = json.dumps(safe_headers)
9597

9698
request.env["spp_api.log"].create(request_log_val)

0 commit comments

Comments
 (0)