Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Sep 6, 2025

  • Fix TupleView._makeViewList to use makeList.inputs instead of original inputs parameter in concat calls
  • Update EmptyView._viewListCount to respect .isNonEmptyParent option
  • Add unit tests for EmptyView._viewListCount

- Fix TupleView._makeViewList to use makeList.inputs instead of original inputs parameter in concat calls
- Update EmptyView._viewListCount to respect .isNonEmptyParent option
- Add unit tests for EmptyView._viewListCount
@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.66%. Comparing base (0f9c1b9) to head (b420870).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/View/TupleView.swift 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   24.61%   24.66%   +0.04%     
==========================================
  Files         470      470              
  Lines       27222    27225       +3     
==========================================
+ Hits         6701     6714      +13     
+ Misses      20521    20511      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit a4cb367 into main Sep 6, 2025
9 of 10 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/misc branch September 6, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants