Skip to content

Commit 409a5de

Browse files
OP-22308: Adding VerifyApplicationHasNoDependenciesTask class to deleteApplication task. (#228)
1 parent 5e383b6 commit 409a5de

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

rbac/custom-stage-orca/src/main/java/com/opsmx/plugin/stage/custom/DeleteApplicationStage.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import javax.validation.constraints.NotNull;
44

5+
import com.netflix.spinnaker.orca.applications.tasks.VerifyApplicationHasNoDependenciesTask;
56
import org.pf4j.Extension;
67
import org.springframework.stereotype.Component;
78

@@ -21,6 +22,7 @@ public class DeleteApplicationStage implements StageDefinitionBuilder {
2122
public void taskGraph(@NotNull StageExecution stage, @NotNull TaskNode.Builder builder) {
2223

2324
builder.withTask("validateApplication", RBACValidationTask.class)
25+
.withTask("verifyNoDependencies", VerifyApplicationHasNoDependenciesTask.class)
2426
.withTask("deleteTask", DeleteApplicationTask.class);
2527
}
2628
}

rbac/custom-stage-orca/src/main/java/com/opsmx/plugin/stage/custom/RBACValidationTask.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,10 @@ public TaskResult execute(StageExecution stage) {
110110

111111
if (stage.getType().equalsIgnoreCase("CreateApplication")) {
112112
finalInput = getOpaInput(application, "createApp", groupList, stage.getExecution().getAuthentication().getUser());
113-
} else {
113+
} else if (stage.getType().equalsIgnoreCase("UpdateApplication")){
114114
finalInput = getOpaInput(application, "updateApp", groupList, stage.getExecution().getAuthentication().getUser());
115+
} else {
116+
finalInput = getOpaInput(application, "deleteApp", groupList, stage.getExecution().getAuthentication().getUser());
115117
}
116118

117119

0 commit comments

Comments
 (0)