Move method to test code.

Author: jcamiel

packages/hurl/src/report/junit/mod.rs

@@ -200,7 +200,7 @@ mod tests {
         let suite = create_testsuite(&testcases, &secrets);
         let doc = XmlDocument::new(suite);
         assert_eq!(
-            doc.to_string().unwrap(),
+            doc.dump(),
             "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\
             <testsuite tests=\"3\" errors=\"1\" failures=\"1\">\
                 <testcase id=\"test.hurl\" name=\"test.hurl\" time=\"0.124\" />\

packages/hurl/src/report/junit/testcase.rs

@@ -119,7 +119,7 @@ mod test {
         let element = Testcase::from(&hurl_result, content, &filename).to_xml(&secrets);
         let doc = XmlDocument::new(element);
         assert_eq!(
-            doc.to_string().unwrap(),
+            doc.dump(),
             r#"<?xml version="1.0" encoding="UTF-8"?><testcase id="test.hurl" name="test.hurl" time="0.230" />"#
         );
     }
@@ -152,7 +152,7 @@ HTTP/1.0 200
         let element = Testcase::from(&hurl_result, content, &filename).to_xml(&secrets);
         let doc = XmlDocument::new(element);
         assert_eq!(
-            doc.to_string().unwrap(),
+            doc.dump(),
             r#"<?xml version="1.0" encoding="UTF-8"?><testcase id="test.hurl" name="test.hurl" time="0.230"><failure>Assert status code
   --&gt; test.hurl:2:10
    |
@@ -189,7 +189,7 @@ HTTP/1.0 200
         let element = Testcase::from(&hurl_result, content, &filename).to_xml(&secrets);
         let doc = XmlDocument::new(element);
         assert_eq!(
-            doc.to_string().unwrap(),
+            doc.dump(),
             r#"<?xml version="1.0" encoding="UTF-8"?><testcase id="test.hurl" name="test.hurl" time="0.230"><error>HTTP connection
   --&gt; test.hurl:1:5
    |

packages/hurl/src/report/junit/xml/writer.rs

@@ -65,15 +65,6 @@ impl From<FromUtf8Error> for WriterError {
 }
 
 impl XmlDocument {
-    /// Convenient method to serialize an XML document to a string.
-    #[allow(dead_code)]
-    pub fn to_string(&self) -> Result<String, WriterError> {
-        let buffer = vec![];
-        let buffer = self.write(buffer)?;
-        let str = String::from_utf8(buffer)?;
-        Ok(str)
-    }
-
     /// Serializes an XML document to a `buffer`.
     pub fn write<W>(&self, buffer: W) -> Result<W, WriterError>
     where
@@ -146,6 +137,15 @@ impl Element {
 mod tests {
     use crate::report::junit::xml::{Element, XmlDocument};
 
+    impl XmlDocument {
+        /// Convenient method to serialize an XML document to a string.
+        pub fn dump(&self) -> String {
+            let buffer = vec![];
+            let buffer = self.write(buffer).unwrap();
+            String::from_utf8(buffer).unwrap()
+        }
+    }
+
     #[test]
     fn write_xml_0() {
         let root = Element::new("catalog")
@@ -208,7 +208,7 @@ mod tests {
             ;
         let doc = XmlDocument { root: Some(root) };
         assert_eq!(
-            doc.to_string().unwrap(),
+            doc.dump(),
             "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\
             <catalog>\
                 <book id=\"bk101\">\