Skip to content

Commit b3cfe52

Browse files
committed
Use Duration instead for FiniteDuration
opendaylight/controller@158ab17 JIRA: LIGHTY-354 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
1 parent 0b459c9 commit b3cfe52

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

lighty-core/lighty-controller/src/test/java/io/lighty/core/controller/config/ConfigLoadingTest.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
import io.lighty.core.controller.impl.util.FileToDatastoreUtils;
1717
import java.io.IOException;
1818
import java.io.InputStream;
19+
import java.time.Duration;
20+
import java.time.temporal.ChronoUnit;
1921
import java.util.HashSet;
2022
import java.util.Set;
2123
import java.util.concurrent.TimeUnit;
@@ -25,7 +27,7 @@
2527
import org.opendaylight.yangtools.binding.meta.YangModuleInfo;
2628
import org.testng.Assert;
2729
import org.testng.annotations.Test;
28-
import scala.concurrent.duration.Duration;
30+
import scala.concurrent.duration.FiniteDuration;
2931

3032
public class ConfigLoadingTest {
3133

@@ -38,14 +40,14 @@ public void loadControllerConfigurationNoDsContexts() throws IOException, Config
3840
Assert.assertNotNull(configuration.getOperDatastoreContext());
3941
DatastoreContext configDatastoreContext = configuration.getConfigDatastoreContext();
4042
Assert.assertEquals(configDatastoreContext.getShardTransactionIdleTimeout(),
41-
Duration.create(10, TimeUnit.MINUTES));
43+
FiniteDuration.apply(10, TimeUnit.MINUTES));
4244
Assert.assertEquals(configDatastoreContext.getOperationTimeoutInMillis(), 5000);
4345
Assert.assertEquals(configDatastoreContext.getShardTransactionCommitTimeoutInSeconds(), 30);
4446
Assert.assertEquals(configDatastoreContext.getShardRaftConfig().getJournalRecoveryLogBatchSize(), 1);
4547
Assert.assertEquals(configDatastoreContext.getShardRaftConfig().getSnapshotBatchCount(), 20000);
4648
Assert.assertEquals(configDatastoreContext.getShardRaftConfig().getSnapshotDataThresholdPercentage(), 12);
4749
Assert.assertEquals(configDatastoreContext.getShardRaftConfig().getHeartBeatInterval(),
48-
Duration.create(500, TimeUnit.MILLISECONDS));
50+
Duration.of(500, ChronoUnit.MILLIS));
4951
Assert.assertEquals(configDatastoreContext.getShardTransactionCommitQueueCapacity(), 50000);
5052
Assert.assertEquals(configDatastoreContext.getShardInitializationTimeout(),
5153
new Timeout(300000, TimeUnit.MILLISECONDS));
@@ -64,14 +66,14 @@ public void loadControllerConfigurationNoDsContexts() throws IOException, Config
6466

6567
DatastoreContext operDatastoreContext = configuration.getOperDatastoreContext();
6668
Assert.assertEquals(operDatastoreContext.getShardTransactionIdleTimeout(),
67-
Duration.create(10, TimeUnit.MINUTES));
69+
FiniteDuration.apply(10, TimeUnit.MINUTES));
6870
Assert.assertEquals(operDatastoreContext.getOperationTimeoutInMillis(), 5000);
6971
Assert.assertEquals(operDatastoreContext.getShardTransactionCommitTimeoutInSeconds(), 30);
7072
Assert.assertEquals(operDatastoreContext.getShardRaftConfig().getJournalRecoveryLogBatchSize(), 1);
7173
Assert.assertEquals(operDatastoreContext.getShardRaftConfig().getSnapshotBatchCount(), 20000);
7274
Assert.assertEquals(operDatastoreContext.getShardRaftConfig().getSnapshotDataThresholdPercentage(), 12);
7375
Assert.assertEquals(operDatastoreContext.getShardRaftConfig().getHeartBeatInterval(),
74-
Duration.create(500, TimeUnit.MILLISECONDS));
76+
Duration.of(500, ChronoUnit.MILLIS));
7577
Assert.assertEquals(operDatastoreContext.getShardTransactionCommitQueueCapacity(), 50000);
7678
Assert.assertEquals(operDatastoreContext.getShardInitializationTimeout(),
7779
new Timeout(300000, TimeUnit.MILLISECONDS));
@@ -161,14 +163,14 @@ public void loadConfigDatastoreCtxTest() throws IOException {
161163
DatastoreConfigurationUtils.DATASTORECTX_CONFIG_ROOT_ELEMENT_NAME, LogicalDatastoreType.CONFIGURATION);
162164
Assert.assertNotNull(dataStoreContext);
163165
Assert.assertEquals(dataStoreContext.getShardTransactionIdleTimeout(),
164-
Duration.create(100, TimeUnit.MILLISECONDS));
166+
FiniteDuration.apply(100, TimeUnit.MILLISECONDS));
165167
Assert.assertEquals(dataStoreContext.getOperationTimeoutInMillis(), 50000);
166168
Assert.assertEquals(dataStoreContext.getShardTransactionCommitTimeoutInSeconds(), 300);
167169
Assert.assertEquals(dataStoreContext.getShardRaftConfig().getJournalRecoveryLogBatchSize(), 10);
168170
Assert.assertEquals(dataStoreContext.getShardRaftConfig().getSnapshotBatchCount(), 200000);
169171
Assert.assertEquals(dataStoreContext.getShardRaftConfig().getSnapshotDataThresholdPercentage(), 15);
170172
Assert.assertEquals(dataStoreContext.getShardRaftConfig().getHeartBeatInterval(),
171-
Duration.create(5000, TimeUnit.MILLISECONDS));
173+
Duration.of(5000, ChronoUnit.MILLIS));
172174
Assert.assertEquals(dataStoreContext.getShardTransactionCommitQueueCapacity(), 500000);
173175
Assert.assertEquals(dataStoreContext.getShardInitializationTimeout(),
174176
new Timeout(3000000, TimeUnit.MILLISECONDS));
@@ -192,14 +194,14 @@ public void loadOperationalDatastoreCtxTest() throws IOException {
192194
DatastoreConfigurationUtils.DATASTORECTX_OPERATIONAL_ROOT_ELEMENT_NAME, LogicalDatastoreType.OPERATIONAL);
193195
Assert.assertNotNull(dataStoreContext);
194196
Assert.assertEquals(dataStoreContext.getShardTransactionIdleTimeout(),
195-
Duration.create(-100, TimeUnit.MILLISECONDS));
197+
FiniteDuration.apply(-100, TimeUnit.MILLISECONDS));
196198
Assert.assertEquals(dataStoreContext.getOperationTimeoutInMillis(), -50000);
197199
Assert.assertEquals(dataStoreContext.getShardTransactionCommitTimeoutInSeconds(), -300);
198200
Assert.assertEquals(dataStoreContext.getShardRaftConfig().getJournalRecoveryLogBatchSize(), -10);
199201
Assert.assertEquals(dataStoreContext.getShardRaftConfig().getSnapshotBatchCount(), -200000);
200202
Assert.assertEquals(dataStoreContext.getShardRaftConfig().getSnapshotDataThresholdPercentage(), 18);
201203
Assert.assertEquals(dataStoreContext.getShardRaftConfig().getHeartBeatInterval(),
202-
Duration.create(-5000, TimeUnit.MILLISECONDS));
204+
Duration.of(-5000, ChronoUnit.MILLIS));
203205
Assert.assertEquals(dataStoreContext.getShardTransactionCommitQueueCapacity(), -500000);
204206
Assert.assertEquals(dataStoreContext.getShardInitializationTimeout(),
205207
new Timeout(-3000000, TimeUnit.MILLISECONDS));

0 commit comments

Comments
 (0)