Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Extend list of EXIF fields getters/setters #22

Open
hanovruslan opened this issue Mar 9, 2015 · 3 comments
Open

[proposal] Extend list of EXIF fields getters/setters #22

hanovruslan opened this issue Mar 9, 2015 · 3 comments

Comments

@hanovruslan
Copy link
Contributor

There are much more useful EXIF fields then existed once.

  • Manufacturer
  • Lens
  • Flash

and many more

@Miljar Miljar added this to the v0.4 milestone Mar 25, 2015
@Miljar Miljar modified the milestones: v1.0, v0.4 Apr 3, 2015
@djmattyg007
Copy link

What would be required to support the manufacturer and flash EXIF fields?

@djmattyg007
Copy link

To clarify, I would be willing to put in the necessary effort to make this happen. I just need a clear idea of what is required.

@Miljar
Copy link
Collaborator

Miljar commented Oct 9, 2016

Hey @djmattyg007, to make this happen, you should do the following:

  • Modify the Exif class: add constants, getters & setters
  • Modify the Mapper classes so that data can be mapped from the source data to the Exif class
  • Ideally you provide an image with the new data in the exif data, so you can create unit tests for the new functionality you added

The process right now is a bit cumbersome. I'm working on a new version which should make these kind of changes easier. I'm lacking time though at the moment, so progress is rather slow :(

Thanks for willing to look further into this issue!

@Miljar Miljar removed this from the v1.0 milestone Dec 30, 2016
@Miljar Miljar mentioned this issue Dec 30, 2016
6 tasks
@Miljar Miljar self-assigned this Dec 30, 2016
@Miljar Miljar added this to the v1.0 milestone Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants