Skip to content

Commit d590b69

Browse files
committed
Fixed docs and configuration files
1 parent 8f7decd commit d590b69

File tree

7 files changed

+25
-32
lines changed

7 files changed

+25
-32
lines changed

.codeclimate.yml

+5-13
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,11 @@ engines:
2929
enabled: true
3030
phpmd:
3131
enabled: true
32-
checks:
33-
CleanCode/ElseExpression:
34-
enabled: false
35-
CleanCode/BooleanArgumentFlag:
36-
enabled: false
37-
Controversial/Superglobals:
38-
enabled: false
39-
Controversial/CamelCaseVariableName:
40-
enabled: false
41-
Design/TooManyPublicMethods:
42-
enabled: false
43-
Design/NpathComplexity:
44-
enabled: false
32+
config:
33+
file_extensions:
34+
- php
35+
- inc
36+
rulesets: "phpmd.xml"
4537
ratings:
4638
paths:
4739
- "**.inc"

CODING_GUIDELINE.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Fork the project, create a feature branch, and send us a pull request.
55
Preferably on a distinct branch.
66

77
To ensure a consistent code base, you should make sure the code follows
8-
the [PSR-2 Coding Standards](http://www.php-fig.org/psr/psr-2/). You can also
8+
the [PSR-12: Extended Coding Style](https://www.php-fig.org/psr/psr-12/). You can also
99
run [php-cs-fixer](https://github.com/FriendsOfPHP/PHP-CS-Fixer) with the
1010
configuration file that can be found in the project root directory.
1111

@@ -24,7 +24,7 @@ As of the V7 your contributions MUST comply the following standards:
2424
- E.g: `$dateFormat = \DATE_ISO8601`
2525

2626
### PHP CORE CLASSES
27-
- Do not imports non-namespaced classes, use an absolute path instead:
27+
- Do not import non-namespaced classes, use an absolute path instead:
2828
- E.g: `$date = new \DateTime();`
2929

3030
### CODE STYLE

CONTRIBUTING.md

+10-8
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,16 @@ Developer notes
2323
If you want to contribute to the repository you will need to install/configure some things first.
2424

2525
To run tests follow the steps:
26-
- Run `./bin/ci/scripts/install_dependencies.sh`
27-
- Run `./vendor/bin/phpcs lib/ --report=summary`
28-
- Run `./vendor/bin/phpmd lib/ ansi phpmd.xml`
29-
- Run `./vendor/bin/phpstan analyse lib/ -l 2 -c phpstan_lite.neon 2>&1`
30-
- Run `php -f ./bin/ci/run_tests.php`
26+
1) Run `./bin/ci/scripts/install_dependencies.sh`
27+
2) Run `./vendor/bin/phpcs lib/ --report=summary`
28+
3) Run `./vendor/bin/phpmd lib/ ansi phpmd.xml`
29+
4) Run `./vendor/bin/phpstan analyse lib/ -l 2 -c phpstan_lite.neon 2>&1`
30+
5) Run `php -f ./bin/ci/run_tests.php`
3131

32-
The last command will run all the tests including the quality tests (phpmd, phpcs, phpstan).
32+
If you are on Windows environment simply run the file `quality.bat` located at the root of the project to run the step 2, 3 and 4 in once.
33+
34+
The last command will run all the unit tests of the project.
3335
If an error appears, fix it then you can submit your pull request.
3436

35-
Don't worry if you don't have some services installed like "memcached", "couchdb", "couchbase", "mongodb", etc.
36-
The tests will be skipped on your computer but will be running in Github CI/Travis CI.
37+
Some tests will be skipped if you don't have special dependencies installed (Arangodb, Couchbase, Couchdb, Firestore credential and SDK, Dynamodb credential, etc.).\
38+
So don't worry if those tests are skipped as long as they **pass** on the Github and Travis CIs.

docs/DRIVERS.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
* Cookie **(REMOVED in V9)**
1111
* A cookie driver to store non-sensitive scalar (only) data. Limited storage up to 4Ko.
1212
* Couchbase **(REMOVED in V9)**
13-
* A very high-performance NoSQL driver using a key-value pair system, replaced by Couchbasev3 as of V9.
14-
* Couchbasev3 **(Added in V8.0.8)**
13+
* A very high-performance NoSQL driver using a key-value pair system, replaced by Couchbasev3 as of v8.0.8.
14+
* Couchbasev3 **(Added in v8.0.8)**
1515
* Same as Couchbase but for Couchbase PHP-SDK 3.0 support.
1616
* Couchdb
1717
* A very high-performance NoSQL driver using a key-value pair system.
@@ -21,7 +21,7 @@
2121
* A development driver that return null for driverRead() and driverIsHit() (get actions) and true for other action such as driverDelete, DriverClear() etc.
2222
* Devtrue **(REMOVED in V9)**
2323
* A development driver that return true for everything including driverCheck().
24-
* Devrandom **(Added in V8.0.8)**
24+
* Devrandom **(Added in v8.0.8)**
2525
* A development driver with configurable factor chance and data length.
2626
* Dynamodb **(Added in V9)**
2727
* An AWS cloud NoSQL driver using a key-value pair system. Be careful when flushing the table as it will delete and recreate the table due to a Dynamodb limitation.
@@ -43,7 +43,7 @@
4343
* A high-performance memory driver using a in-memory data structure storage. Less efficient than Redis driver as it is an embedded library.
4444
* Redis
4545
* A very high-performance memory driver using a in-memory data structure storage. More efficient than Predis driver as it is an compiled library.
46-
* Riak **(REMOVED in V8.0.6)**
46+
* Riak **(REMOVED in v8.0.6)**
4747
* A very high-performance NoSQL driver using a key-value pair system.
4848
* Sqlite
4949
* A Sqlite driver that use serialization for storing data for regular performances. A _$path_ config must be specified, else the system temporary directory will be used.

lib/Phpfastcache/CacheContract.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
<?php
22

33
/**
4+
*
45
* This file is part of Phpfastcache.
56
*
67
* @license MIT License (MIT)
78
*
89
* For full copyright and license information, please see the docs/CREDITS.txt and LICENCE files.
910
*
10-
* @author Squiz Pty Ltd <[email protected]>
11-
* @author Squiz Pty Ltd <[email protected]>
11+
* @author Georges.L (Geolim4) <[email protected]>
12+
* @author Contributors https://github.com/PHPSocialNetwork/phpfastcache/graphs/contributors
1213
*/
13-
1414
declare(strict_types=1);
1515

1616
namespace Phpfastcache;

lib/Phpfastcache/Config/AbstractConfigurationOption.php

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
* @author Georges.L (Geolim4) <[email protected]>
1111
* @author Contributors https://github.com/PHPSocialNetwork/phpfastcache/graphs/contributors
1212
*/
13-
1413
declare(strict_types=1);
1514

1615
namespace Phpfastcache\Config;

lib/Phpfastcache/Helper/Psr16Adapter.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ public function deleteMultiple(iterable $keys): bool
196196
return $this->internalCacheInstance->deleteItems($keys);
197197
}
198198

199-
throw new phpFastCacheInvalidArgumentException('$keys must be an array/Traversable instance.');
199+
throw new PhpfastcacheInvalidArgumentException('$keys must be an array/Traversable instance.');
200200
} catch (PhpfastcacheInvalidArgumentException $e) {
201201
throw new PhpfastcacheSimpleCacheException($e->getMessage(), 0, $e);
202202
}

0 commit comments

Comments
 (0)