Add support for @template on @method tags

Virtual methods declared via @method PHPDoc tags can now define their
own
template parameters using the <T of Bound> syntax (e.g.
@method TVal get<TVal of mixed>(TVal $default)). Template inference at
call
sites works the same as for real methods. Includes tests and demo.
Removes
completed todo item T19.

Author: AJenbo

docs/CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+- **`@template` on `@method` tags.** Virtual methods declared via `@method` PHPDoc tags can now define their own template parameters using the `<T of Bound>` syntax (e.g. `@method TVal get<TVal of mixed>(TVal $default)`). Template inference at call sites works the same as for real methods.
 - **Laravel custom Eloquent builder support.** Models using the `#[UseEloquentBuilder]` attribute now have their custom builder's methods forwarded as static methods on the model. `query()`, `newQuery()`, and `newModelQuery()` return the custom builder type with correct generic model substitution. Contributed by @MingJen in https://github.com/AJenbo/phpantom_lsp/pull/118.
 
 ### Fixed

docs/todo.md

@@ -25,7 +25,6 @@ within the same impact tier.
 
 | #   | Item                                                                                                                  | Impact     | Effort |
 | --- | --------------------------------------------------------------------------------------------------------------------- | ---------- | ------ |
-| T19 | [`@template` on `@method` tags](todo/type-inference.md#t19-template-on-method-tags)                                   | High       | Medium |
 | D10 | [PHPMD diagnostic proxy](todo/diagnostics.md#d10-phpmd-diagnostic-proxy)                                              | Low        | Medium |
 | A35 | [Convert to arrow function](todo/actions.md#a35-convert-to-arrow-function) (only non-void single-expression closures) | Low-Medium | Low    |
 | C2  | [`#[ArrayShape]` return shapes on stub functions](todo/completion.md#c2-arrayshape-return-shapes-on-stub-functions)   | Medium     | Medium |

docs/todo/type-inference.md

@@ -686,40 +686,5 @@ blowup.
   `references/psalm/src/Psalm/Type.php`
 
 
-## T19. `@template` on `@method` tags
-
-Virtual methods declared via `@method` PHPDoc tags cannot currently
-define their own template parameters. The `extract_method_tags`
-function in `src/docblock/virtual_members.rs` always sets
-`template_params: Vec::new()`.
-
-This is important for Laravel Facade support, where the underlying
-accessor class has generic methods that are proxied through the
-Facade's `@method` tags:
-
-```php
-/**
- * @method static TValue get<TValue>(string $key, TValue $default)
- */
-class Config extends Facade {}
-```
-
-PHPStan syntax: `@method <T> T get(class-string<T> $class)`
-
-### Implementation
-
-1. Parse method-level template params from `@method` tag syntax in
-   `extract_method_tags` (`src/docblock/virtual_members.rs`).
-2. Store them in `MethodInfo::template_params` on the synthesized
-   virtual method.
-3. Ensure call-site template inference (`resolve_call_return_types`)
-   works with virtual methods the same way it does with real methods.
-
-### References
-
-- PHPStan: `MethodTagParser` at
-  `references/phpstan-src/src/PhpDoc/Tag/MethodTagParser.php`
-- PHPStan rule tests:
-  `references/phpstan-src/tests/PHPStan/Rules/Generics/MethodTagTemplateTypeRuleTest.php`
 
 

examples/demo.php

@@ -3540,10 +3540,40 @@ function globalKeywordDemo(): void {
     $globalPen->write();                  // Pen — resolved from top-level scope via `global`
 }
 
+// ── Method-Tag Template ─────────────────────────────────────────────────────
+
+class MethodTagTemplateDemo
+{
+    public function demo(): void
+    {
+        // @method tags with <T of Bound> template params resolve at call sites.
+        $registry = new ScaffoldingMethodTagTemplate();
+
+        // TVal inferred from argument type
+        $pen = new Pen('demo');
+        $result = $registry->get($pen);
+        $result->write();                 // TVal = Pen
+
+        // Inline chain
+        $registry->get(new Pencil())->sketch(); // TVal = Pencil
+    }
+}
+
 // ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
 // ┃  SCAFFOLDING — Supporting definitions below this line.              ┃
 
-// ── Template-param @mixin scaffolding ───────────────────────────────────────
+// ── Method-Tag Template scaffolding ────────────────────────────────────────────
+
+/**
+ * @method TVal get<TVal of mixed>(TVal $default)
+ */
+class ScaffoldingMethodTagTemplate
+{
+    /** @return mixed */
+    public function __call(string $name, array $args): mixed { return $args[0] ?? null; }
+}
+
+// ── Template-param @mixin scaffolding ─────────────────────────────────────────
 interface ScaffoldingAstNodeInterface {
     public function getStartColumn(): int;
     public function getEndColumn(): int;

src/docblock/templates.rs

@@ -277,7 +277,7 @@ pub fn extract_generics_tag(docblock: &str, tag: &str) -> Vec<(String, Vec<PhpTy
 
 /// Recursively walk a [`PhpType`] tree and collect `(template_name, param_name)` pairs
 /// for every template parameter reference found anywhere in the type.
-fn collect_template_bindings(
+pub(crate) fn collect_template_bindings(
     ty: &PhpType,
     template_params: &[String],
     param_name: &str,