Clean up roadmap

Author: AJenbo

docs/todo.md

@@ -20,7 +20,6 @@ with each step.
 | [Diagnostics](todo/diagnostics.md) | `@deprecated` warnings, resolution-failure diagnostics, unused `use` dimming, suppression intelligence |
 | [Code Actions](todo/actions.md) | Import class, remove unused imports, implement missing methods, null coalescing simplification, extract function, inline variable, extract variable, inline function/method, switch→match |
 | [LSP Features](todo/lsp-features.md) | Find references, document highlighting, document/workspace symbols, rename, code lens, inlay hints, PHPDoc generation, partial result streaming |
-| [Hover](todo/hover.md) | Deprecation messages, constant values, member origin indicators, enum case listing, trait method summaries |
 | [Signature Help](todo/signature-help.md) | Parameter descriptions, signature-level docs, default values, attribute/closure support |
 | [Laravel](todo/laravel.md) | Model property gaps, relationship methods, type narrowing, custom builders |
 | [Blade](todo/blade.md) | Preprocessor, component support, cross-file view intelligence |
@@ -33,30 +32,6 @@ with each step.
 
 ---
 
-## Sprint 2.5 — Parallel file processing (0.5.0)
-
-This sprint delivers parallel file processing for workspace-wide
-operations (find references, go-to-implementation, self-scan,
-diagnostics). The prerequisite items replace shared data structures
-with reference-counted wrappers so that parallel threads share data
-cheaply instead of deep-cloning.
-
-| # | Item | Effort | Domain | Doc Link | Status |
-|---|---|---|---|---|---|
-| 85 | `Arc<String>` for file content in `open_files` | Low | Performance | [performance.md §5](todo/performance.md#5-arcstring-for-file-content-in-open_files) | ✅ Done |
-| 86 | `Arc<SymbolMap>` to avoid snapshot cloning | Low | Performance | [performance.md §6](todo/performance.md#6-arcsymbolmap-to-avoid-snapshot-cloning) | ✅ Done |
-| 95 | Parallel file processing | Medium | Indexing | [indexing.md §3](todo/indexing.md#phase-3-parallel-file-processing) | ✅ Done (initial) |
-| 14 | Signature help fires on function definition sites | Low | Bug Fix | [bugs.md §14](todo/bugs.md#14-signature-help-fires-on-function-definition-sites) | ✅ Done |
-
-**After Sprint 2.5:** `ensure_workspace_indexed` parses files across
-multiple cores using `std::thread::scope`. File content and symbol
-maps are shared by reference instead of deep-cloned. Transient entry
-eviction after GTI and find references has been removed; parsed files
-stay cached for faster repeat queries. Priority-aware scheduling
-(preempting batch work for interactive requests) is deferred.
-
----
-
 ## Sprint 3 — Refactoring & deferred performance
 
 Extract Function is the remaining refactoring pillar. Inline Variable,

docs/todo/bugs.md

@@ -14,137 +14,4 @@ Items are ordered by **impact** (descending), then **effort** (ascending).
 
 ---
 
-## 1. Short-name collisions in `find_implementors`
-**Impact: Low · Effort: Low (fixed)**
-
-**Status:** Fixed. `class_implements_or_extends` now compares
-fully-qualified names when a namespace is available. The short-name
-fallback is only used when FQN information is absent. `seen_fqns` in
-`find_implementors` deduplicates by FQN (built from `name` +
-`file_namespace`) instead of by short name.
-
----
-
-## 2. GTD fires on parameter variable names and class declaration names
-**Impact: Medium · Effort: Low (fixed)**
-
-**Status:** Fixed. Three layers suppress self-referential jumps:
-
-1. `resolve_from_symbol` returns `None` for `ClassDeclaration` and
-   `MemberDeclaration` symbol kinds (the cursor is at the definition).
-2. `lookup_var_def_kind_at` detects when the cursor is on a variable
-   at its definition site (parameter, assignment LHS, foreach binding,
-   catch binding) and returns `None` before `find_var_definition` runs.
-3. A self-reference guard in `resolve_definition` suppresses jumps
-   when the resolved location points back to the cursor position.
-
-Tested with `test_goto_definition_parameter_at_definition_returns_none`
-and related tests in `definition_variables.rs`.
-
----
-
-## 3. Relationship classification matches short name only
-**Impact: Low · Effort: Low (fixed)**
-
-**Status:** Fixed. `classify_relationship` now checks whether a
-namespace-qualified return type lives under
-`Illuminate\Database\Eloquent\Relations\` before classifying.
-Unqualified short names (the common case for body-inferred types and
-use-imported docblock annotations) still match by short name only.
-A custom `App\Relations\HasMany` is no longer misclassified.
-
----
-
-## 4. Go-to-implementation misses transitive implementors
-**Impact: Medium · Effort: Medium (fixed)**
-
-**Status:** Fixed. `class_implements_or_extends` already walks the
-parent class chain transitively (up to `MAX_INHERITANCE_DEPTH`) and
-checks interface-extends chains recursively. Classes that extend a
-concrete class which itself implements the target interface are found
-correctly. Tested with `test_implementation_transitive_via_parent`,
-`test_implementation_skips_abstract_subclasses`, and deep interface
-inheritance chains.
-
----
-
-## 5. Go-to-implementation Phase 5 should only walk user PSR-4 roots
-**Impact: Low · Effort: Low (fixed)**
-
-**Status:** Fixed. PSR-4 mappings now come exclusively from
-`composer.json` (user code only). Vendor PSR-4 mappings are no longer
-loaded (see §7), so Phase 5 inherently walks only user roots.
-
----
-
-## 6. Go-to-definition does not check the classmap
-**Impact: Medium · Effort: Low (fixed)**
-
-**Status:** Fixed. `resolve_class_reference`, `resolve_self_static_parent`,
-and `resolve_type_hint_string_to_location` now check the Composer classmap
-(FQN → file path) between the class_index lookup and the PSR-4 fallback.
-A cold Ctrl+Click on a vendor class resolves through the classmap without
-needing vendor PSR-4 mappings.
-
----
-
-## 7. Vendor PSR-4 mappings removed
-**Impact: Low · Effort: Low (fixed)**
-
-**Status:** Fixed. `parse_vendor_autoload_psr4` has been removed.
-`parse_composer_json` no longer reads `vendor/composer/autoload_psr4.php`.
-PSR-4 mappings come exclusively from the project's own `composer.json`
-(`autoload.psr-4` and `autoload-dev.psr-4`). The `is_vendor` flag on
-`Psr4Mapping` has been removed.
-
-All resolution paths that could hit a vendor class now check the classmap
-first (§6). If the classmap is missing or stale, vendor classes fail to
-resolve visibly (fix: run `composer dump-autoload`). This reduces startup
-time and memory for projects with large dependency trees.
-
-**Note for Rename Symbol:** when rename support is implemented, the
-handler should reject renames for symbols whose definition lives under
-the vendor directory. The user cannot meaningfully rename third-party
-code. Use `vendor_uri_prefix` to detect this and return an appropriate
-error message.
-
----
-
-## 13. Evict transiently-loaded files from ast_map after GTI and Find References
-**Impact: Low · Effort: Low (fixed → superseded)**
-
-**Status:** Superseded. The original fix added post-scan eviction
-(`evict_transient_entries`, `evict_transient_ast_entries`) to remove
-`ast_map`, `symbol_maps`, `use_map`, and `namespace_map` entries that
-were added during GTI and find-references scans.
-
-The eviction has since been removed. With `Arc<SymbolMap>` and
-`Arc<String>` reducing per-entry memory cost, keeping parsed files
-cached is a better trade-off: subsequent operations (a second
-find-references call, go-to-definition on a cross-file symbol)
-benefit from the work already done without re-parsing. The eviction
-functions (`evict_transient_entries`, `evict_transient_ast_entries`,
-`evict_transient_inner`) and their `pre_scan_uris` snapshots have
-been removed.
-
----
-
-## 14. Signature help fires on function definition sites
-**Impact: Low · Effort: Low (fixed)**
-
-**Status:** Fixed. `detect_call_site_text_fallback` now calls
-`is_function_definition_paren` before extracting a call expression.
-The check walks backward from the open parenthesis through the
-function name (if any) and whitespace, looking for the `function` or
-`fn` keyword. This suppresses signature help for named functions
-(`function foo(`), anonymous functions (`function (`), arrow functions
-(`fn(`), and method definitions (`public function bar(`).
-
-The AST-based detection path was already safe because `CallSite`
-entries are only emitted for actual call expressions, never for
-function/method definitions.
-
-Tested with `suppressed_on_named_function_definition`,
-`suppressed_on_anonymous_function`, `suppressed_on_arrow_function`,
-`suppressed_on_method_definition`, and
-`not_suppressed_on_actual_function_call` in `signature_help_tests.rs`.
+No outstanding bugs.

docs/todo/completion.md

@@ -133,24 +133,19 @@ parsing and should feed into the same `return_type` field on
 ---
 
 ## 4. `#[Deprecated]` structured deprecation metadata
-**Status: ✅ Implemented**
-
-PHPantom reads the `#[Deprecated]` attribute (FQN:
-`JetBrains\PhpStorm\Deprecated`) on classes, interfaces, traits, enums,
-methods, properties, constants, and standalone functions. The `reason`
-and `since` fields appear in hover, completion strikethrough, and
-deprecation diagnostics. When both a docblock `@deprecated` tag and the
-attribute are present, the docblock message takes priority.
-
-The `replacement` field is parsed and stored but not yet wired to a
-code action. Once the general code-action infrastructure lands, a
-"replace deprecated call" quick-fix can use the template (e.g.
-`"exif_read_data(%parametersList%)"`) to offer automatic replacement.
-
-**Remaining work:**
-- Wire `replacement` to a code action (blocked on code-action infra).
-- Use `since` to make deprecation warnings version-aware (suppress when
-  targeting a PHP version older than the `since` value).
+**Impact: Low · Effort: Low**
+
+The `#[Deprecated]` attribute is parsed and wired into hover, completion
+strikethrough, and deprecation diagnostics. Two pieces remain:
+
+- **Replacement code action.** The `replacement` field is parsed and
+  stored but not yet wired to a code action. Once the general
+  code-action infrastructure lands, a "replace deprecated call"
+  quick-fix can use the template (e.g.
+  `"exif_read_data(%parametersList%)"`) to offer automatic replacement.
+- **Version-aware suppression.** Use the `since` field to suppress
+  deprecation warnings when targeting a PHP version older than the
+  `since` value.
 
 ---
 

docs/todo/config.md

@@ -98,7 +98,5 @@ Controls which external tools PHPantom proxies for diagnostics.
 
 ## Implementation order
 
-1. ✅ **Config loading.** Read `.phpantom.toml` from the workspace root on `initialized`. Deserialize with `toml` + `serde`. Missing file means all defaults. *Done — `src/config.rs` module, loaded during `initialized` in `server.rs`. Parse errors are reported as a warning to the user.*
-2. **Config writing.** When PHPantom prompts the user and gets an answer, write or update the relevant key. Preserve comments and formatting (use `toml_edit` crate).
-3. ✅ **PHP version override.** Wire `[php].version` into the existing version detection path. *Done — config override takes precedence over `composer.json` detection.*
-4. **Diagnostic proxying.** Wire `[diagnostics]` toggles into the proxy infrastructure as each provider is implemented. *Partially done — `unresolved-member-access` toggle is wired; external tool toggles (`phpstan`, `phpmd`, etc.) await proxy infrastructure.*
+1. **Config writing.** When PHPantom prompts the user and gets an answer, write or update the relevant key. Preserve comments and formatting (use `toml_edit` crate).
+2. **Diagnostic proxying.** Wire `[diagnostics]` toggles into the proxy infrastructure as each provider is implemented. *Partially done — `unresolved-member-access` toggle is wired; external tool toggles (`phpstan`, `phpmd`, etc.) await proxy infrastructure.*

docs/todo/diagnostics.md

@@ -11,76 +11,20 @@ within the same impact tier.
 ---
 
 ## 2. Resolution-failure diagnostics
-**Impact: Medium · Effort: Medium** *(mostly done — unresolved class/interface, unresolved member access, and unresolvable subject type implemented; unresolved function and unresolved PHPDoc type remain)*
-
-Report diagnostics only for symbols and types that PHPantom's own engine
-failed to resolve. This is **not** a general PHP linter — we don't check
-argument counts, type compatibility, or missing semicolons. The goal is
-twofold:
-
-1. **Surface bugs in our engine.** On well-typed projects, every
-   diagnostic is a false positive that points at a resolution code path
-   we need to fix. This gives us a live regression signal.
-2. **Guide under-typed projects.** On projects that aren't fully typed,
-   the diagnostics show exactly where adding annotations would unlock
-   completion and go-to-definition.
+**Impact: Medium · Effort: Medium**
 
-All diagnostics should be published on `textDocument/didOpen` and
-`textDocument/didChange` (debounced). Severity is **Warning** for
-unresolved types (the code may still run fine) and **Hint** or
-**Information** for softer signals.
+Unresolved class/interface, unresolved member access, and unresolvable
+subject type diagnostics are already implemented. Two diagnostic types
+remain:
 
 ### Diagnostics to emit
 
 | Diagnostic | Trigger | Severity | Example |
 |---|---|---|---|
-| ✅ Unresolved class/interface | A type hint, `extends`, `implements`, `new`, or `::` reference that `find_or_load_class` cannot resolve after all phases (ast_map → classmap → PSR-4 → stubs) | Warning | `Class 'App\Foo' not found` | *Done — `diagnostics::unknown_classes` module* |
 | Unresolved function | A function call that `find_or_load_function` cannot resolve (global functions, namespaced functions, stubs) | Warning | `Function 'do_thing' not found` |
-| ✅ Unresolved member access | `->method()` or `->property` on a type we *did* resolve, but the member doesn't exist after full resolution (inheritance + virtual providers) | Warning | `Method 'frobnicate' not found on class 'App\Bar'` | *Done — `diagnostics::unknown_members` module. PHPactor benchmark fixtures `lots_of_missing_methods` and `method_chain` enabled in `benches/completion.rs`.* |
-| ✅ Unresolvable subject type (opt-in) | `->method()`, `?->method()`, or `::method()` where PHPantom cannot resolve the subject type at all (e.g. `mixed`, untyped variable, uninferrable return type) | Hint | `Cannot resolve type of '$x'. Add a type annotation or PHPDoc tag to enable full IDE support.` | *Done — `diagnostics::unresolved_member_access` module. Off by default; enable via `[diagnostics] unresolved-member-access = true` in `.phpantom.toml`.* |
 | Unresolved type in PHPDoc | A `@return`, `@param`, `@var`, `@throws`, `@mixin`, or `@extends` tag references a class that cannot be resolved | Information | `Type 'SomeAlias' in @return could not be resolved` |
 
 
-### What we explicitly do NOT report
-
-- Syntax errors (Mago already handles that; we use error-tolerant parsing)
-- Argument count / type mismatches (that's PHPStan's job)
-- Unused variables, imports, or dead code
-- Missing return types or parameter types
-- Code style violations
-
-### Implementation plan
-
-1. **Add `publishDiagnostics` capability** in `initialize` response and
-   store a handle to the client notification sender.
-2. **Collect diagnostics during `update_ast`** — the symbol map walk
-   already visits every class reference, member access, and function
-   call. At each site, attempt resolution; on failure, record a
-   `DiagnosticEntry { range, message, severity }`.
-3. **Debounce and publish** — after `update_ast` completes (on open or
-   change), send `textDocument/publishDiagnostics` with the collected
-   entries. Debounce changes to ~200 ms so fast typing doesn't spam.
-4. **Clear on close** — send an empty diagnostics array when a file is
-   closed.
-5. **User opt-out** — respect a config flag (e.g.
-   `phpantom.diagnostics.enabled: bool`, default `true`) so users who
-   rely solely on PHPStan / Psalm can turn ours off.
-
-### Design notes
-
-- **False positive budget:** treat every false positive as a bug. If a
-  diagnostic fires on valid, well-typed code, the fix goes in the
-  resolution engine, not in a suppression list. This keeps us honest.
-- **No cross-file diagnostics** — only diagnose the file being
-  edited/opened. We don't scan the whole project.
-- **Stubs are authoritative** — if a symbol exists in phpstorm-stubs,
-  it's resolved. We don't warn about `array_map` not being found
-  because a stub was missing.
-- **Performance** — resolution is already happening for completion and
-  definition; diagnostics piggyback on the same code paths. The
-  incremental cost should be small since we're just collecting failures
-  that currently get silently swallowed.
-
 ---
 
 ## 3. Diagnostic suppression intelligence

docs/todo/hover.md

@@ -429,11 +429,8 @@ structures.
 go-to-implementation, self-scan, diagnostics) by processing files in
 parallel with priority awareness.
 
-**Prerequisites (from [performance.md](performance.md)):**
-
-- **§3 `RwLock` for read-heavy maps.** ✅ Fixed.
-- **§5 `Arc<String>` for file content.** ✅ Fixed.
-- **§6 `Arc<SymbolMap>` to avoid snapshot cloning.** ✅ Fixed.
+All prerequisites (§3 `RwLock`, §5 `Arc<String>`, §6 `Arc<SymbolMap>`)
+are complete.
 
 ### Current state (partial)
 
@@ -536,20 +533,20 @@ scanning, and complete completion item detail.
 
 **Prerequisites (from [performance.md](performance.md)):**
 
-- **§1 FQN secondary index.** ✅ Done. `fqn_index` provides O(1)
+- **§1 FQN secondary index.** Done. `fqn_index` provides O(1)
   lookups by fully-qualified name, so the second pass populating
   `ast_map` with thousands of entries no longer causes linear scans.
 - **§2 `Arc<ClassInfo>`.** Full indexing stores a `ClassInfo` for every
   class in the project. Without `Arc`, every resolution clones the
   entire struct out of the map. With `Arc`, retrieval is a
   reference-count increment. This is the difference between full
   indexing using ~200 MB vs. ~500 MB for a large project.
-- **§3 `RwLock`.** The second pass writes to `ast_map` at Low priority
+- **§3 `RwLock`.** Done. The second pass writes to `ast_map` at Low priority
   while High-priority LSP requests read from it. `Mutex` would force
   every completion/hover request to wait for the current background
   parse to finish its map insertion. `RwLock` lets reads proceed
   concurrently with other reads; only the brief write window blocks.
-- **§4 `HashSet` dedup.** ✅ Done. All member deduplication during
+- **§4 `HashSet` dedup.** Done. All member deduplication during
   inheritance merging now uses `HashSet` lookups, bringing the
   per-resolution cost from O(N²) to O(N).
 

docs/todo/indexing.md

@@ -329,20 +329,6 @@ visible — well within our per-file performance budget.
 
 ---
 
-## 10. Reverse jump: implementation → interface method declaration
-**Impact: Medium · Effort: Low (fixed)**
-
-**Status:** Fixed. When go-to-implementation is invoked on a
-`MemberDeclaration` symbol in a concrete class, the handler walks the
-class's interfaces (including those inherited from parent classes) and
-parent abstract classes to find the prototype method declaration and
-returns its location. Conversely, invoking go-to-implementation on a
-method declaration inside an interface or abstract class finds the
-concrete implementations. Tested with same-file and transitive
-inheritance scenarios.
-
----
-
 ## 11. No go-to-definition for built-in (stub) functions and constants
 **Impact: Medium · Effort: Medium**