chore(deps): bump to Flutter 3.32.0 (#161)

* chore(deps): bump to Flutter 3.32.0

* style: trailing commas are back in style ig

* fix: bump analyzer_plugin

* ci: bump timeout

Author: lishaduck

.github/workflows/ci.yaml

@@ -24,13 +24,9 @@ permissions:
 jobs:
   setup:
     name: Setup
-    needs: []
     timeout-minutes: 5
     runs-on: ubuntu-latest
 
-    strategy:
-      fail-fast: false
-
     steps:
       - name: 📚 Git checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -81,7 +77,7 @@ jobs:
   build:
     name: Build
     needs: ["setup"]
-    timeout-minutes: ${{ (matrix.target == 'web') && 5 || 10 }}
+    timeout-minutes: ${{ (matrix.target == 'web') && 5 || 20 }}
     runs-on: ${{ matrix.os }}
 
     strategy:
@@ -224,6 +220,9 @@ jobs:
     timeout-minutes: 7
     runs-on: ubuntu-latest
 
+    permissions:
+      id-token: write
+
     steps:
       - name: 📚 Git checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -268,9 +267,9 @@ jobs:
         continue-on-error: true
       - name: 📊 Upload code coverage
         if: ${{ !cancelled() }}
-        uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4.6.0
+        uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
         with:
-          token: ${{ secrets.CODECOV_TOKEN }}
+          use_oidc: true
           files: packages/app/coverage/lcov.info
           fail_ci_if_error: true
           verbose: true
@@ -299,6 +298,8 @@ jobs:
           cache: true
       - name: 🌐 Disable analytics
         run: flutter --disable-analytics
+      - name: 📦 Install dependencies
+        run: dart pub get --enforce-lockfile
       - name: ✨ Verify formatting
         run: dart format . --output=none --set-exit-if-changed
 
@@ -344,7 +345,6 @@ jobs:
 
   spell-check:
     name: Check Spelling
-    needs: []
     runs-on: ubuntu-latest
 
     steps:
@@ -370,7 +370,6 @@ jobs:
 
   link-check:
     name: Check Links
-    needs: []
     timeout-minutes: 2
     runs-on: ubuntu-latest
 
@@ -384,7 +383,6 @@ jobs:
 
   markdownlint:
     name: Lint Markdown
-    needs: []
     timeout-minutes: 4
     runs-on: ubuntu-latest
 
@@ -405,3 +403,26 @@ jobs:
           # Surprisingly, the default is to only lint the project root.
           globs: |
             **/*.md
+
+  zizmor:
+    name: Run zizmor
+    timeout-minutes: 1
+    runs-on: ubuntu-latest
+
+    permissions:
+      contents: read
+      security-events: write
+      actions: read
+
+    steps:
+      - name: 📚 Git Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          submodules: recursive
+          clean: true
+          persist-credentials: false
+          set-safe-directory: true
+      - name: 🌈 Run zizmor
+        uses: zizmorcore/zizmor-action@2520132f44b3ed84916048d32e5c7153fc739fe7 # v0.0.3
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

packages/_analysis_options/lib/analysis_options.yaml

@@ -53,6 +53,7 @@ linter:
     prefer_mixin: true
     unnecessary_null_aware_operator_on_extension_on_nullable: true
     unreachable_from_main: true
+    require_trailing_commas: true
 
     # Rules with false-positives, not in VGA
     discarded_futures: true
@@ -65,13 +66,16 @@ linter:
     specify_nonobvious_property_types: true
 
     # New/updated rules, not yet in VGA
-    use_truncating_division: true
     avoid_futureor_void: true
-    unnecessary_underscores: true
-    strict_top_level_inference: true
+    use_null_aware_elements: true
+    unnecessary_ignore: true
+    use_truncating_division: true
 
     # Newly (or soon-to-be) deprecated rules, still in VGA
     unnecessary_await_in_return: false
-    require_trailing_commas: false
+
 # Additional information about this file can be found at
 # https://dart.dev/guides/language/analysis-options
+
+formatter:
+  trailing_commas: preserve

packages/_analysis_options/pubspec.yaml

@@ -7,8 +7,8 @@ issue_tracker: https://github.com/PHS-TSA/nexus/issues
 repository: https://github.com/PHS-TSA/nexus.git
 
 environment:
-  sdk: ^3.7.0
+  sdk: ^3.8.0
 resolution: workspace
 
 dependencies:
-  very_good_analysis: ^7.0.0
+  very_good_analysis: ^8.0.0-rc.1

packages/app/lib/src/app/app.dart

@@ -18,7 +18,9 @@ class App extends ConsumerStatefulWidget with Bootstrap {
   /// {@macro harvest_hub.app}
   ///
   /// Construct a new [App] widget.
-  const App({super.key});
+  const App({
+    super.key,
+  });
 
   @override
   ConsumerState<App> createState() => _AppState();
@@ -80,7 +82,9 @@ class _AppState extends ConsumerState<App> with RestorationMixin {
 
 /// Eagerly initializes providers.
 class _EagerInitialization extends ConsumerWidget {
-  const _EagerInitialization({required this.child});
+  const _EagerInitialization({
+    required this.child,
+  });
 
   final Widget child;
 

packages/app/lib/src/app/bootstrap.dart

@@ -31,8 +31,10 @@ typedef GetSharedPreferences =
     });
 
 /// The environment needed to bootstrap the app.
-typedef BootstrapEnv =
-    ({RunApp runApp, GetSharedPreferences getSharedPreferences});
+typedef BootstrapEnv = ({
+  RunApp runApp,
+  GetSharedPreferences getSharedPreferences,
+});
 
 /// Turn any widget into a flow-blown app.
 mixin Bootstrap implements Widget {

packages/app/lib/src/app/create_post.dart

@@ -29,7 +29,9 @@ class CreatePost extends HookConsumerWidget {
   /// {@macro harvest_hub.app.create_post}
   ///
   /// Construct a new [CreatePost] widget.
-  const CreatePost({super.key});
+  const CreatePost({
+    super.key,
+  });
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {
@@ -99,10 +101,12 @@ class CreatePost extends HookConsumerWidget {
         ),
       ),
       insetPadding: EdgeInsets.symmetric(
-        horizontal:
-            context.sizeClass == MaterialWindowSizeClass.compact ? 0.0 : 64.0,
-        vertical:
-            context.sizeClass == MaterialWindowSizeClass.compact ? 0.0 : 48.0,
+        horizontal: context.sizeClass == MaterialWindowSizeClass.compact
+            ? 0.0
+            : 64.0,
+        vertical: context.sizeClass == MaterialWindowSizeClass.compact
+            ? 0.0
+            : 48.0,
       ),
       child: Padding(
         padding: EdgeInsets.all(
@@ -216,7 +220,10 @@ class CreatePost extends HookConsumerWidget {
 ///
 /// Notably, it also allows the user to remove images from the list.
 class _UploadedImagesView extends HookConsumerWidget {
-  const _UploadedImagesView({super.key});
+  const _UploadedImagesView({
+    super.key,
+  });
+
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     final uploadedImages = ref.watch(uploadedImagesServiceProvider);

packages/app/lib/src/app/wrapper.dart

@@ -15,7 +15,10 @@ class Wrapper extends StatelessWidget {
   /// {@macro harvest_hub.app.wrapper}
   ///
   /// Construct a new [Wrapper] widget.
-  const Wrapper({required this.child, super.key});
+  const Wrapper({
+    required this.child,
+    super.key,
+  });
 
   /// The child widget to display.
   final Widget child;
@@ -80,11 +83,10 @@ class _DesktopWrapper extends StatelessWidget {
         ],
       ), // TODO(MattsAttack): Implement rail here, similar to Google article.
       floatingActionButton: FloatingActionButton(
-        onPressed:
-            () async => showDialog<void>(
-              context: context,
-              builder: (context) => const CreatePost(),
-            ),
+        onPressed: () async => showDialog<void>(
+          context: context,
+          builder: (context) => const CreatePost(),
+        ),
         child: const Icon(Icons.create),
       ), // TODO(MattsAttack): Change to form on top of feed for desktop.
     );
@@ -112,11 +114,10 @@ class _MobileWrapper extends StatelessWidget {
   Widget build(BuildContext context) {
     return Scaffold(
       floatingActionButton: FloatingActionButton(
-        onPressed:
-            () async => showDialog<void>(
-              context: context,
-              builder: (context) => const CreatePost(),
-            ),
+        onPressed: () async => showDialog<void>(
+          context: context,
+          builder: (context) => const CreatePost(),
+        ),
         child: const Icon(Icons.create),
       ),
       body: child,

packages/app/lib/src/app/wrapper_page.dart

@@ -16,7 +16,9 @@ class WrapperPage extends ConsumerWidget {
   /// {@macro harvest_hub.app.wrapper_page}
   ///
   /// Construct a new [WrapperPage] widget.
-  const WrapperPage({super.key});
+  const WrapperPage({
+    super.key,
+  });
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {

packages/app/lib/src/features/auth/presentation/auth/log_in_page.dart

@@ -22,7 +22,10 @@ class LogInPage extends HookConsumerWidget {
   /// {@macro harvest_hub.features.auth.presentation.auth.login_page}
   ///
   /// Construct a new [LogInPage] widget.
-  const LogInPage({super.key, AuthCallback? onResult}) : _onResult = onResult;
+  const LogInPage({
+    super.key,
+    AuthCallback? onResult,
+  }) : _onResult = onResult;
 
   final AuthCallback? _onResult;
 
@@ -39,10 +42,13 @@ class LogInPage extends HookConsumerWidget {
 }
 
 class _DesktopLogInPage extends HookConsumerWidget {
-  const _DesktopLogInPage({super.key, AuthCallback? onResult})
-    : _onResult = onResult;
+  const _DesktopLogInPage({
+    super.key,
+    AuthCallback? onResult,
+  }) : _onResult = onResult;
 
   final AuthCallback? _onResult;
+
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     final formKey = useGlobalKey<FormState>();
@@ -178,10 +184,13 @@ class _DesktopLogInPage extends HookConsumerWidget {
 }
 
 class _MobileLogInPage extends HookConsumerWidget {
-  const _MobileLogInPage({super.key, AuthCallback? onResult})
-    : _onResult = onResult;
+  const _MobileLogInPage({
+    super.key,
+    AuthCallback? onResult,
+  }) : _onResult = onResult;
 
   final AuthCallback? _onResult;
+
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     final formKey = useGlobalKey<FormState>();
@@ -250,10 +259,9 @@ class _MobileLogInPage extends HookConsumerWidget {
                           'Welcome to Harvest Hub!',
                           style: TextStyle(
                             fontSize: 24,
-                            color:
-                                Theme.of(
-                                  context,
-                                ).colorScheme.onPrimaryContainer,
+                            color: Theme.of(
+                              context,
+                            ).colorScheme.onPrimaryContainer,
                           ),
                           textAlign: TextAlign.center,
                         ),

packages/app/lib/src/features/auth/presentation/auth/sign_up_page.dart

@@ -24,7 +24,10 @@ class SignUpPage extends HookConsumerWidget {
   /// {@macro harvest_hub.features.auth.presentation.auth.sign_up_page}
   ///
   /// Construct a new [SignUpPage] widget.
-  const SignUpPage({super.key, AuthCallback? onResult}) : _onResult = onResult;
+  const SignUpPage({
+    super.key,
+    AuthCallback? onResult,
+  }) : _onResult = onResult;
 
   final AuthCallback? _onResult;
 
@@ -41,10 +44,13 @@ class SignUpPage extends HookConsumerWidget {
 }
 
 class _DesktopSignUpPage extends HookConsumerWidget {
-  const _DesktopSignUpPage({super.key, AuthCallback? onResult})
-    : _onResult = onResult;
+  const _DesktopSignUpPage({
+    super.key,
+    AuthCallback? onResult,
+  }) : _onResult = onResult;
 
   final AuthCallback? _onResult;
+
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     final formKey = useGlobalKey<FormState>();
@@ -190,10 +196,13 @@ class _DesktopSignUpPage extends HookConsumerWidget {
 }
 
 class _MobileSignUpPage extends HookConsumerWidget {
-  const _MobileSignUpPage({super.key, AuthCallback? onResult})
-    : _onResult = onResult;
+  const _MobileSignUpPage({
+    super.key,
+    AuthCallback? onResult,
+  }) : _onResult = onResult;
 
   final AuthCallback? _onResult;
+
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     final formKey = useGlobalKey<FormState>();
@@ -262,10 +271,9 @@ class _MobileSignUpPage extends HookConsumerWidget {
                           'Welcome to Harvest Hub!',
                           style: TextStyle(
                             fontSize: 24,
-                            color:
-                                Theme.of(
-                                  context,
-                                ).colorScheme.onPrimaryContainer,
+                            color: Theme.of(
+                              context,
+                            ).colorScheme.onPrimaryContainer,
                           ),
                           textAlign: TextAlign.center,
                         ),