Skip to content

Commit 24ebd51

Browse files
Crypt32Crypt32
committed
cleanup
1 parent 8ea92c2 commit 24ebd51

8 files changed

+328
-180
lines changed

‎.editorconfig

+191
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,191 @@
1+
[*.{cs,vb}]
2+
3+
# IDE0049: Simplify Names
4+
dotnet_style_predefined_type_for_locals_parameters_members = false:silent
5+
dotnet_style_operator_placement_when_wrapping = beginning_of_line
6+
tab_width = 4
7+
indent_size = 4
8+
end_of_line = crlf
9+
dotnet_style_coalesce_expression = true:suggestion
10+
dotnet_style_null_propagation = true:suggestion
11+
dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
12+
dotnet_style_prefer_auto_properties = true:suggestion
13+
dotnet_style_object_initializer = true:suggestion
14+
dotnet_style_collection_initializer = true:suggestion
15+
dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
16+
dotnet_style_prefer_conditional_expression_over_assignment = true:silent
17+
dotnet_style_prefer_conditional_expression_over_return = true:silent
18+
dotnet_style_explicit_tuple_names = true:suggestion
19+
dotnet_style_prefer_inferred_tuple_names = true:suggestion
20+
dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
21+
dotnet_style_prefer_compound_assignment = true:suggestion
22+
dotnet_style_prefer_simplified_interpolation = true:suggestion
23+
dotnet_style_namespace_match_folder = true:suggestion
24+
dotnet_style_readonly_field = true:suggestion
25+
dotnet_style_predefined_type_for_member_access = false:error
26+
dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
27+
dotnet_style_allow_statement_immediately_after_block_experimental = true:silent
28+
dotnet_style_allow_multiple_blank_lines_experimental = true:silent
29+
dotnet_code_quality_unused_parameters = all:suggestion
30+
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
31+
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
32+
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent
33+
dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
34+
dotnet_style_qualification_for_property = false:warning
35+
dotnet_style_qualification_for_field = false:silent
36+
dotnet_style_qualification_for_method = false:warning
37+
dotnet_style_qualification_for_event = false:warning
38+
39+
[*.cs]
40+
csharp_indent_labels = flush_left
41+
csharp_space_around_binary_operators = before_and_after
42+
csharp_using_directive_placement = outside_namespace:silent
43+
csharp_prefer_simple_using_statement = true:suggestion
44+
csharp_prefer_braces = true:error
45+
csharp_style_namespace_declarations = file_scoped:suggestion
46+
csharp_style_prefer_method_group_conversion = true:silent
47+
csharp_style_prefer_top_level_statements = true:silent
48+
csharp_style_expression_bodied_methods = false:silent
49+
csharp_style_expression_bodied_constructors = false:silent
50+
csharp_style_expression_bodied_operators = false:silent
51+
csharp_style_expression_bodied_properties = true:silent
52+
csharp_style_expression_bodied_indexers = true:silent
53+
csharp_style_expression_bodied_accessors = true:silent
54+
csharp_style_expression_bodied_lambdas = true:silent
55+
csharp_style_expression_bodied_local_functions = false:silent
56+
[*.cs]
57+
#### Naming styles ####
58+
59+
# Naming rules
60+
61+
dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
62+
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
63+
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
64+
65+
dotnet_naming_rule.interface_should_be_begins_with_i.severity = error
66+
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
67+
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
68+
69+
dotnet_naming_rule.private_method_should_be_camel_case.severity = suggestion
70+
dotnet_naming_rule.private_method_should_be_camel_case.symbols = private_method
71+
dotnet_naming_rule.private_method_should_be_camel_case.style = camel_case
72+
73+
dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
74+
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
75+
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
76+
77+
# Symbol specifications
78+
79+
dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
80+
dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal
81+
dotnet_naming_symbols.types.required_modifiers =
82+
83+
dotnet_naming_symbols.interface.applicable_kinds = interface
84+
dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal
85+
dotnet_naming_symbols.interface.required_modifiers =
86+
87+
dotnet_naming_symbols.private_method.applicable_kinds = method
88+
dotnet_naming_symbols.private_method.applicable_accessibilities = private
89+
dotnet_naming_symbols.private_method.required_modifiers =
90+
91+
dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
92+
dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal
93+
dotnet_naming_symbols.non_field_members.required_modifiers =
94+
95+
# Naming styles
96+
97+
dotnet_naming_style.pascal_case.required_prefix =
98+
dotnet_naming_style.pascal_case.required_suffix =
99+
dotnet_naming_style.pascal_case.word_separator =
100+
dotnet_naming_style.pascal_case.capitalization = pascal_case
101+
102+
dotnet_naming_style.begins_with_i.required_prefix = I
103+
dotnet_naming_style.begins_with_i.required_suffix =
104+
dotnet_naming_style.begins_with_i.word_separator =
105+
dotnet_naming_style.begins_with_i.capitalization = pascal_case
106+
107+
dotnet_naming_style.camel_case.required_prefix =
108+
dotnet_naming_style.camel_case.required_suffix =
109+
dotnet_naming_style.camel_case.word_separator =
110+
dotnet_naming_style.camel_case.capitalization = camel_case
111+
112+
dotnet_naming_style.pascal_case.required_prefix =
113+
dotnet_naming_style.pascal_case.required_suffix =
114+
dotnet_naming_style.pascal_case.word_separator =
115+
dotnet_naming_style.pascal_case.capitalization = pascal_case
116+
csharp_style_prefer_null_check_over_type_check = true:suggestion
117+
csharp_style_throw_expression = true:suggestion
118+
csharp_style_prefer_local_over_anonymous_function = true:suggestion
119+
csharp_prefer_simple_default_expression = true:suggestion
120+
csharp_style_prefer_index_operator = true:suggestion
121+
csharp_style_prefer_range_operator = true:suggestion
122+
csharp_style_implicit_object_creation_when_type_is_apparent = true:suggestion
123+
csharp_style_prefer_tuple_swap = true:suggestion
124+
csharp_style_prefer_utf8_string_literals = true:suggestion
125+
csharp_style_inlined_variable_declaration = true:suggestion
126+
csharp_style_deconstructed_variable_declaration = true:suggestion
127+
csharp_style_unused_value_assignment_preference = discard_variable:suggestion
128+
csharp_style_unused_value_expression_statement_preference = discard_variable:silent
129+
csharp_prefer_static_local_function = true:suggestion
130+
csharp_style_prefer_readonly_struct = true:suggestion
131+
csharp_style_allow_embedded_statements_on_same_line_experimental = true:silent
132+
csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true:silent
133+
csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true:silent
134+
csharp_style_conditional_delegate_call = true:suggestion
135+
csharp_style_prefer_switch_expression = true:suggestion
136+
csharp_style_prefer_pattern_matching = true:silent
137+
csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
138+
csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
139+
csharp_style_prefer_not_pattern = true:suggestion
140+
csharp_style_prefer_extended_property_pattern = true:suggestion
141+
csharp_style_var_for_built_in_types = false:suggestion
142+
csharp_style_var_when_type_is_apparent = true:suggestion
143+
csharp_style_var_elsewhere = false:suggestion
144+
145+
[*.vb]
146+
#### Naming styles ####
147+
148+
# Naming rules
149+
150+
dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
151+
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
152+
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
153+
154+
dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
155+
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
156+
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
157+
158+
dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
159+
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
160+
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
161+
162+
# Symbol specifications
163+
164+
dotnet_naming_symbols.interface.applicable_kinds = interface
165+
dotnet_naming_symbols.interface.applicable_accessibilities = public, friend, private, protected, protected_friend, private_protected
166+
dotnet_naming_symbols.interface.required_modifiers =
167+
168+
dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
169+
dotnet_naming_symbols.types.applicable_accessibilities = public, friend, private, protected, protected_friend, private_protected
170+
dotnet_naming_symbols.types.required_modifiers =
171+
172+
dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
173+
dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, friend, private, protected, protected_friend, private_protected
174+
dotnet_naming_symbols.non_field_members.required_modifiers =
175+
176+
# Naming styles
177+
178+
dotnet_naming_style.begins_with_i.required_prefix = I
179+
dotnet_naming_style.begins_with_i.required_suffix =
180+
dotnet_naming_style.begins_with_i.word_separator =
181+
dotnet_naming_style.begins_with_i.capitalization = pascal_case
182+
183+
dotnet_naming_style.pascal_case.required_prefix =
184+
dotnet_naming_style.pascal_case.required_suffix =
185+
dotnet_naming_style.pascal_case.word_separator =
186+
dotnet_naming_style.pascal_case.capitalization = pascal_case
187+
188+
dotnet_naming_style.pascal_case.required_prefix =
189+
dotnet_naming_style.pascal_case.required_suffix =
190+
dotnet_naming_style.pascal_case.word_separator =
191+
dotnet_naming_style.pascal_case.capitalization = pascal_case

‎Asn1Parser.sln

+7-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11

22
Microsoft Visual Studio Solution File, Format Version 12.00
3-
# Visual Studio Version 16
4-
VisualStudioVersion = 16.0.29102.190
3+
# Visual Studio Version 17
4+
VisualStudioVersion = 17.4.33213.308
55
MinimumVisualStudioVersion = 10.0.40219.1
66
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Asn1Parser", "Asn1Parser\Asn1Parser.csproj", "{F18F1812-FD65-4206-8869-B1DBB4D59AC8}"
77
EndProject
8+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{E1957F17-219C-4FE0-878D-4DB5AAEA6A6C}"
9+
ProjectSection(SolutionItems) = preProject
10+
.editorconfig = .editorconfig
11+
EndProjectSection
12+
EndProject
813
Global
914
GlobalSection(SolutionConfigurationPlatforms) = preSolution
1015
Debug|Any CPU = Debug|Any CPU

‎Asn1Parser/Asn1Builder.cs

+2-27
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,8 @@ public Asn1Builder AddBoolean(Boolean value) {
4242
/// <param name="value">
4343
/// Value to encode.
4444
/// </param>
45-
/// <exception cref="ArgumentNullException">
46-
/// <strong>value</strong> parameter is null.
47-
/// </exception>
4845
/// <returns>Current instance with added value.</returns>
4946
public Asn1Builder AddInteger(BigInteger value) {
50-
if (value == null) {
51-
throw new ArgumentNullException(nameof(value));
52-
}
5347
_rawData.AddRange(new Asn1Integer(value).RawData);
5448
return this;
5549
}
@@ -296,14 +290,8 @@ public Asn1Builder AddIA5String(String value) {
296290
/// <param name="value">
297291
/// Value to encode.
298292
/// </param>
299-
/// <exception cref="ArgumentNullException">
300-
/// <strong>value</strong> parameter is null.
301-
/// </exception>
302293
/// <returns>Current instance with added value.</returns>
303294
public Asn1Builder AddUtcTime(DateTime value) {
304-
if (value == null) {
305-
throw new ArgumentNullException(nameof(value));
306-
}
307295
_rawData.AddRange(new Asn1UtcTime(value).RawData);
308296
return this;
309297
}
@@ -313,14 +301,8 @@ public Asn1Builder AddUtcTime(DateTime value) {
313301
/// <param name="value">
314302
/// Value to encode.
315303
/// </param>
316-
/// <exception cref="ArgumentNullException">
317-
/// <strong>value</strong> parameter is null.
318-
/// </exception>
319304
/// <returns>Current instance with added value.</returns>
320305
public Asn1Builder AddGeneralizedTime(DateTime value) {
321-
if (value == null) {
322-
throw new ArgumentNullException(nameof(value));
323-
}
324306
_rawData.AddRange(new Asn1GeneralizedTime(value).RawData);
325307
return this;
326308
}
@@ -330,19 +312,12 @@ public Asn1Builder AddGeneralizedTime(DateTime value) {
330312
/// <param name="value">
331313
/// Value to encode.
332314
/// </param>
333-
/// <exception cref="ArgumentNullException">
334-
/// <strong>value</strong> parameter is null.
335-
/// </exception>
336315
/// <returns>Current instance with added value.</returns>
337316
/// <remarks>
338317
/// Dates prior to 2050 year are encoded using <strong>UTC Time</strong> and dates beginning with 2050 year are encoded using
339318
/// <strong>Generalized Time</strong>.
340319
/// </remarks>
341320
public Asn1Builder AddRfcDateTime(DateTime value) {
342-
if (value == null) {
343-
throw new ArgumentNullException(nameof(value));
344-
}
345-
346321
_rawData.AddRange(value.Year < 2050
347322
? new Asn1UtcTime(value).RawData
348323
: new Asn1GeneralizedTime(value).RawData);
@@ -477,7 +452,7 @@ public Asn1Builder AddImplicit(Byte implicitTag, Byte[] value, Boolean mustEncod
477452
}
478453
var asn = new Asn1Reader(value);
479454
asn.BuildOffsetMap();
480-
var valueCopy = value.ToArray();
455+
Byte[] valueCopy = value.ToArray();
481456
valueCopy[0] = (Byte)(0x80 + implicitTag);
482457
_rawData.AddRange(valueCopy);
483458
}
@@ -518,7 +493,7 @@ public Asn1Builder AddExplicit(Byte explicitTag, Byte[] value, Boolean mustEncod
518493
} else {
519494
var asn = new Asn1Reader(value);
520495
asn.BuildOffsetMap();
521-
var valueCopy = value.ToArray();
496+
Byte[] valueCopy = value.ToArray();
522497
valueCopy[0] = (Byte)(0xa0 + explicitTag);
523498
_rawData.AddRange(valueCopy);
524499
}

‎Asn1Parser/Asn1Class.cs

+30-26
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,32 @@
11
namespace SysadminsLV.Asn1Parser {
2-
/// <summary>
3-
/// Defines ASN.1 tagging classes.
4-
/// </summary>
5-
public enum Asn1Class : byte {
6-
/// <summary>
7-
/// Represents Universal tag class.
8-
/// </summary>
9-
UNIVERSAL = 0, // 0x00
10-
/// <summary>
11-
/// Represents Constructed tag class.
12-
/// </summary>
13-
CONSTRUCTED = 32, // 0x20
14-
/// <summary>
15-
/// Represents Application tag class.
16-
/// </summary>
17-
APPLICATION = 64, // 0x40
18-
/// <summary>
19-
/// <strong>CONTEXT-SPECIFIC</strong> distinguishes members of a sequence or set, the alternatives of a CHOICE, or
20-
/// universally tagged set members.
21-
/// </summary>
22-
CONTEXT_SPECIFIC = 128, // 0x80
23-
/// <summary>
24-
/// Represents Private tag class.
25-
/// </summary>
26-
PRIVATE = 192 // 0xc0
27-
}
2+
/// <summary>
3+
/// Defines ASN.1 tagging classes.
4+
/// </summary>
5+
public enum Asn1Class : System.Byte {
6+
/// <summary>
7+
/// Represents Universal tag class.
8+
/// </summary>
9+
UNIVERSAL = 0, // 0x00
10+
/// <summary>
11+
/// Represents Constructed tag class.
12+
/// </summary>
13+
CONSTRUCTED = 32, // 0x20
14+
/// <summary>
15+
/// Represents Application tag class.
16+
/// </summary>
17+
APPLICATION = 64, // 0x40
18+
/// <summary>
19+
/// <strong>CONTEXT-SPECIFIC</strong> distinguishes members of a sequence or set, the alternatives of a CHOICE, or
20+
/// universally tagged set members.
21+
/// </summary>
22+
CONTEXT_SPECIFIC = 128, // 0x80
23+
/// <summary>
24+
/// Represents Private tag class.
25+
/// </summary>
26+
PRIVATE = 192, // 0xc0
27+
/// <summary>
28+
/// Represents universal tag mask that allows to extract universal type from non-universal class.
29+
/// </summary>
30+
UNIVERSAL_MASK = 31
31+
}
2832
}

‎Asn1Parser/Asn1InvalidTagException.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public Asn1InvalidTagException(String message) : base(message) {
2020
}
2121
/// <inheritdoc />
2222
public Asn1InvalidTagException(Int32 offset)
23-
: base(String.Format("ASN1 bad tag value met at offset:{0}.", offset)) {
23+
: base($"ASN1 bad tag value met at offset:{offset}.") {
2424
HResult = unchecked((Int32)0x8009310b);
2525
Offset = offset;
2626
}

‎Asn1Parser/Asn1Parser.csproj

+3
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,7 @@
3131
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)'=='Release|net472'">
3232
<DocumentationFile>bin\Release\net472\SysadminsLV.Asn1Parser.xml</DocumentationFile>
3333
</PropertyGroup>
34+
<ItemGroup>
35+
<None Include="..\.editorconfig" Link=".editorconfig" />
36+
</ItemGroup>
3437
</Project>

0 commit comments

Comments
 (0)