Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing legal acknowledgement in the dialog #69

Closed
mars3142 opened this issue Sep 12, 2016 · 5 comments
Closed

missing legal acknowledgement in the dialog #69

mars3142 opened this issue Sep 12, 2016 · 5 comments

Comments

@mars3142
Copy link

I can only add the license, but there is no way to add the notices.

E.g. watch at https://github.com/h6ah4i/android-advancedrecyclerview - this isn't possible right now with your library or miss I something?

@hameno
Copy link
Member

hameno commented Sep 12, 2016

I'm not sure what you mean. Notices are automatically displayed based on the license you define in the licenses.xml, take a look at the sample app on how it works.

@mars3142
Copy link
Author

Did you open the linked project? Where would you add the content of the NOTICE file? The LICENSE file is clear, but not the NOTICE.

@hameno
Copy link
Member

hameno commented Sep 12, 2016

Yes, I opened it. It is not necessary to add those files, they follow a common pattern and are auto-generated. Please take a look at the sample app.

@hameno hameno closed this as completed Sep 12, 2016
@mars3142
Copy link
Author

But this notices can be everything and not just autogenerated as you said. Okay, will find another way to use it.

@hameno
Copy link
Member

hameno commented Sep 12, 2016

You can always add your own license class and register it in https://github.com/PSDev/LicensesDialog/blob/master/library/src/main/java/de/psdev/licensesdialog/LicenseResolver.java#L70 if it has a custom notice text. All included licenses have the default notice texts that the license requires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants