Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When [Check Links with rel="nofollow"] is unchecked, relatives URLs (starting with "/") are still browsed #73

Open
mevb opened this issue Sep 5, 2017 · 1 comment
Labels

Comments

@mevb
Copy link

mevb commented Sep 5, 2017

Hello,

First of all... ...nice Job !

Here is an example of link with relative URL that fails to be skipped when option [ Check Links with rel="nofollow" ] is disabled :

<a href="/some_path/some_page.html" rel="nofollow">Link Text</a>

This relative URL is interpreted by browsers as : "[ http: | https ]://[ current_page_domain ]/some_path/some_page.html"

Why Check-My-Links fails ?

Because it ignores [ Check Links with rel="nofollow" ] option for URLs which doesn't start with "http", so URLs starting with "/" are browsed anway !

Hope this would help,

Manuel

@mevb mevb changed the title Nofollow fails with relatives URL (starting with "/") When [Check Links with rel="nofollow"] is unchecked relatives URL (starting with "/") are still browsed Sep 8, 2017
@mevb mevb changed the title When [Check Links with rel="nofollow"] is unchecked relatives URL (starting with "/") are still browsed When [Check Links with rel="nofollow"] is unchecked, relatives URLs (starting with "/") are still browsed Sep 8, 2017
@nextofken
Copy link

snag_1f301069

This is also affecting our ability to use this tool. See screen shot, the Logout link (yellow arrow, hidden behind Link Results) is still being followed. You can see it in the console (highlighted) and it has the relative link with nofollow. Once that link is checked all subsequent links 'pass' because they are actually redirecting to the login page.

Love the tool otherwise, it took us weeks to get selenium to perform this same function correctly and I had been hoping to use your plugin instead as it was a lot more light weight than the similar selenium implementation (also anyone on the team can use your plugin not just the techies). Any chance for a bug fix / update soon? Appreciate it.

@chasers chasers added the Bug label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants