fix(gosdk): change signature of ImportFile to accept content as []byte and set Content-Type during ExportFile (#500)

Author: kklimonda-cl

assets/pango/client.go

@@ -971,7 +971,7 @@ func (c *Client) Communicate(ctx context.Context, cmd util.PangoCommand, strip b
 }
 
 // ImportFile imports the given file into PAN-OS.
-func (c *Client) ImportFile(ctx context.Context, cmd *xmlapi.Import, content, filename, fp string, strip bool, ans any) ([]byte, *http.Response, error) {
+func (c *Client) ImportFile(ctx context.Context, cmd *xmlapi.Import, content []byte, filename, fp string, strip bool, ans any) ([]byte, *http.Response, error) {
 	if cmd == nil {
 		return nil, nil, fmt.Errorf("cmd is nil")
 	}
@@ -1002,7 +1002,7 @@ func (c *Client) ImportFile(ctx context.Context, cmd *xmlapi.Import, content, fi
 		return nil, nil, err
 	}
 
-	if _, err = io.Copy(w2, strings.NewReader(content)); err != nil {
+	if _, err = io.Copy(w2, bytes.NewReader(content)); err != nil {
 		return nil, nil, err
 	}
 
@@ -1038,6 +1038,8 @@ func (c *Client) ExportFile(ctx context.Context, cmd *xmlapi.Export, ans any) (s
 		return "", nil, nil, err
 	}
 
+	req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+
 	b, resp, err := c.sendRequest(ctx, req, false, ans)
 	if err != nil {
 		return "", b, resp, err

assets/pango/util/pangoclient.go

@@ -34,7 +34,7 @@ type PangoClient interface {
 
 	// Specialized communication functions around specific XPI API commands.
 	MultiConfig(context.Context, *xmlapi.MultiConfig, bool, url.Values) ([]byte, *http.Response, *xmlapi.MultiConfigResponse, error)
-	ImportFile(context.Context, *xmlapi.Import, string, string, string, bool, any) ([]byte, *http.Response, error)
+	ImportFile(context.Context, *xmlapi.Import, []byte, string, string, bool, any) ([]byte, *http.Response, error)
 	ExportFile(context.Context, *xmlapi.Export, any) (string, []byte, *http.Response, error)
 
 	// Operational functions in use by one or more resources / data sources / namespaces.

pkg/translate/structs.go

@@ -937,7 +937,6 @@ const structToXmlMarshalersTmpl = `
   {{- if .IsXmlContainer }}{{ continue }}{{ end }}
 func (o *{{ .XmlStructName }}) MarshalFromObject(s {{ .StructName }}) {
   {{- range .Fields }}
-    // FieldType: {{ .FieldType }}
     {{- if .IsInternal }}{{ continue }}{{- end }}
     {{- if eq .FieldType "object" }}
 	if s.{{ .Name.CamelCase }} != nil {