Skip to content

Feature Request - add 'net5.0-windows' support #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
makeProjectGreatAgain opened this issue Nov 10, 2021 · 0 comments
Open

Feature Request - add 'net5.0-windows' support #60

makeProjectGreatAgain opened this issue Nov 10, 2021 · 0 comments

Comments

@makeProjectGreatAgain
Copy link
Contributor

makeProjectGreatAgain commented Nov 10, 2021

I have added 'net5.0-windows' support for ExceptionReporter.WinForms in #59 PR.
I am going to update other projects in the solution ( Demo, WPF etc ) if it is ok

Also, I want to mention that there are some disadvantages of supporting both NetFramework and .NET Core. You will need to use different versions of Handlebars, AutoMoq
ExceptionReporter.WinForms.csproj

  <ItemGroup Condition=" '$(TargetFramework)' == 'net40' ">
		<PackageReference Include="Handlebars.Net" Version="1.9.0" />
                ...
  </ItemGroup>
  <ItemGroup Condition="'$(TargetFramework)' == 'net5.0-windows' ">		
                ...
		<PackageReference Include="Handlebars.Net" Version="2.0.2" />
		<PackageReference Include="System.Management" Version="6.0.0" />
                <PackageReference Include="System.Resources.Extensions" Version="6.0.0" />
  </ItemGroup>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant