Position riders before API teleportation #13342
Open
+166
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous teleportation logic would call Entity#positionRider for the "teleportation" of passengers in the same dimension. This prevented plugins that aggressively teleport entities on a per-tick basis from allowing players to get out of sync with their vehicles as the vanilla teleport logic simply performs a relative repositioning of the passengers to the vehicle location. The introduced diff now repositions the passengers onto their vehicle before computing their relative offset and repositioning.
lynxplay
added
the
publish-pr
|
Last updated for: a9f8ec56b9c25325dd3de7fb59ccd8accfd5336f. Download the Paperclip jar for this pull request: paper-13342.zip Maven PublicationThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven("https://maven-prs.papermc.io/Paper/pr13342") {
name = "Maven for PR #13342" // https://github.com/PaperMC/Paper/pull/13342
mavenContent {
includeModule("io.papermc.paper", "dev-bundle")
includeModule("io.papermc.paper", "paper-api")
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous teleportation logic would call Entity#positionRider for the
"teleportation" of passengers in the same dimension.
This prevented plugins that aggressively teleport entities on a per-tick
basis from allowing players to get out of sync with their vehicles as
the vanilla teleport logic simply performs a relative repositioning of
the passengers to the vehicle location.
The introduced diff now repositions the passengers onto their vehicle
before computing their relative offset and repositioning.
Resolves: #13239