Add new dynamic versions table #21
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes use of JS and the new Parchment mappings version endpoint to dynamically list out the latest version for each available Minecraft version. The current implementation sorts the MC versions using the info from the launcher manifest, and falling back to a hardcoded array if that is not available. The current impl. also replaces the rows of the table with new rows, so that the original rows (which uses version badges) of the table remain if the script cannot access the versions endpoint.
- Include the CSV gem, as it is no longer part of the standard set. - Update the WDM gem. - Simplify the platform declarations for Windows to ":windows".
The regular gem (which doesn't pull and build from GitHub) is enough for any non-Windows platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #12 by replacing the existing static versions table with a new dynamic versions table. This makes use of JS and the new Parchment mappings version endpoint to dynamically list out the latest version for each available Minecraft version.
The current implementation sorts the MC versions using the info from the launcher manifest, and falling back to a hardcoded array if that is not available. It also replaces the rows of the table with new rows, so that the original rows (which uses version badges) of the table remain if the script cannot access the versions endpoint.
This PR also does some miscellaneous fixes to the Gemfile for errors and warnings I encountered while installing Jekyll on my Windows machine.
As of PR creation, this is a draft since I am not quite sure of the final UX we want (if we should just have the table be blank if no JS is available, or some instructions pop up to find the latest versions).