Merge pull request #69 from ParentSquare/update-specs-for-updated-gems

Fix minor spec failures for updated gems

Author: justinhoward

Gemfile

@@ -12,15 +12,17 @@ not_jruby = %i[ruby mingw x64_mingw].freeze
 
 gem 'activesupport', '>= 4.2'
 gem 'byebug', platforms: not_jruby
-# Open source licensed elasticsearch
-gem 'honeybadger', '>= 2.0'
 gem 'irb', '~> 1.0'
 # Minimum of 0.5.0 for specific error classes
 gem 'mysql2', '>= 0.5.0', platforms: not_jruby
 gem 'redcarpet', '~> 3.5', platforms: not_jruby
 gem 'rspec_junit_formatter', '~> 0.4'
 gem 'yard', '~> 0.9.25', platforms: not_jruby
 
+if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.4')
+  gem 'honeybadger', '>= 2.0'
+end
+
 if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.6')
   gem 'rubocop', '~> 1.32.0'
   gem 'rubocop-rspec', '~> 2.12'

spec/events/honeybadger_listener_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'honeybadger/ruby'
-
 RSpec.describe Faulty::Events::HoneybadgerListener do
   let(:circuit) { Faulty::Circuit.new('test_circuit') }
   let(:error) { StandardError.new('fail') }
@@ -11,6 +9,9 @@
   end
 
   before do
+    skip 'Honeybadger only supports >= Ruby 2.4' unless Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.4')
+    require 'honeybadger/ruby'
+
     Honeybadger.configure do |c|
       c.backend = 'test'
       c.api_key = 'test'

spec/events/log_listener_spec.rb

@@ -19,6 +19,10 @@
     io.read.strip
   end
 
+  before do
+    require 'logger'
+  end
+
   context 'when Rails is available' do
     before do
       l = logger

spec/patch/redis_spec.rb

@@ -109,8 +109,8 @@ def faulty_cause(error)
       expect { good_redis.ping }.to raise_error do |error|
         expect(error).to be_a(::Redis::BaseConnectionError)
         expect(faulty_cause(error)).to be_a(Faulty::Patch::Redis::BusyError)
-        expect(faulty_cause(error).message).to eq(
-          'BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE.'
+        expect(faulty_cause(error).message).to match(
+          /BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE/
         )
       end