Update dependency NUnit.Analyzers to 4.10.0 (#5053)

* Update dependency NUnit.Analyzers to 4.10.0

* Swap the assert

* Make the class abstract

---------

Co-authored-by: dependencyupdates[bot] <218638057+dependencyupdates[bot]@users.noreply.github.com>
Co-authored-by: Tamara Rivera <[email protected]>

Author: dependencyupdates[bot]

src/Directory.Packages.props

@@ -52,7 +52,7 @@
     <PackageVersion Include="NServiceBus.Transport.PostgreSql" Version="8.1.9" />
     <PackageVersion Include="NuGet.Versioning" Version="6.14.0" />
     <PackageVersion Include="NUnit" Version="4.4.0" />
-    <PackageVersion Include="NUnit.Analyzers" Version="4.7.0" />
+    <PackageVersion Include="NUnit.Analyzers" Version="4.10.0" />
     <PackageVersion Include="NUnit3TestAdapter" Version="5.2.0" />
     <PackageVersion Include="OpenTelemetry.Exporter.Console" Version="1.9.0" />
     <PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.9.0" />

src/ServiceControl.Persistence.Tests/EnsureSettingsInContainer.cs

@@ -13,7 +13,7 @@ public void CheckForBothTypes()
             var baseSettings = ServiceProvider.GetRequiredService<PersistenceSettings>();
 
             var actualType = baseSettings.GetType();
-            Assert.That(typeof(PersistenceSettings), Is.Not.EqualTo(actualType));
+            Assert.That(actualType, Is.Not.EqualTo(typeof(PersistenceSettings)));
 
             // Persistence implementation must also register the same singleton as the persister-specific type
             var settingsAsActualType = ServiceProvider.GetRequiredService(actualType);

src/ServiceControl.Transports.Tests/FullEndpointTestFixture.cs

@@ -7,7 +7,8 @@
     using ServiceControl.Infrastructure;
 
     [TestFixture]
-    class FullEndpointTestFixture
+
+    abstract class FullEndpointTestFixture
     {
         [SetUp]
         public virtual async Task Setup()

src/ServiceControl.Transports.Tests/TransportTestFixture.cs

@@ -18,12 +18,13 @@
     using Transports;
 
     [TestFixture]
-    class TransportTestFixture
+
+    abstract class TransportTestFixture
     {
         [SetUp]
         public virtual async Task Setup()
         {
-            //used for loggers outside of ServiceControl (i.e. transports and core) to use the logger factory defined here
+            //used for loggers outside ServiceControl (i.e. transports and core) to use the logger factory defined here
             LogManager.UseFactory(new ExtensionsLoggerFactory(new TestContextAppenderFactory(Microsoft.Extensions.Logging.LogLevel.Warning)));
             LoggerUtil.ActiveLoggers = Loggers.Test;
             configuration = new TransportTestsConfiguration();

src/ServiceControlInstaller.Engine.UnitTests/Configuration/InstallationFixture.cs

@@ -3,7 +3,7 @@
     using System.IO;
     using NUnit.Framework;
 
-    public class InstallationFixture
+    public abstract class InstallationFixture
     {
         [SetUp]
         public void SetUp()