Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQQuery could benefit from http client factory #4493

Open
danielmarbach opened this issue Oct 3, 2024 · 0 comments
Open

RabbitMQQuery could benefit from http client factory #4493

danielmarbach opened this issue Oct 3, 2024 · 0 comments

Comments

@danielmarbach
Copy link
Contributor

Describe the suggested improvement

The RabbitMQQuery currently news up a fixed http client because it has to pass the extracted credentials to the client. By moving it to the http client factory some of the client configuration could be externalized. It might also simplify testing and remove the necessity for having a virtual method.

The tricky part might be that the http client extensions require information to be available at service collection time. We would have to find a way to pass the credentials validated and extracted during the initialization of the query (which means the container is already closed for modifications) to the client being created.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant