Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external configuration providers #4522

Open
DavidBoike opened this issue Oct 10, 2024 · 0 comments
Open

Add external configuration providers #4522

DavidBoike opened this issue Oct 10, 2024 · 0 comments
Labels

Comments

@DavidBoike
Copy link
Member

DavidBoike commented Oct 10, 2024

Describe the feature.

ServiceControl can be configured via configuration file or environment variable, and since version 5.3.0 the environment variables have been documented in addition to the App config keys in the documentation for the Error instance, Audit instance, and Monitoring instance.

What is missing is the ability to configure settings from a centralized source such as Azure App Configuration, Consul, or other tools.

To use Azure App Config, for instance, a single dedicated environment variable would be necessary to configure the App Config connection string, and perhaps another for environment, and if those were present, the app would reach out to the service to download the configuration settings. These would participate with the settings readers for the App Config and EnvVar readers. (That is, unless the XML-based app.config has been replaced by configuration based on Microsoft.Extensions.Configuration.)

Additional Context

Note that it doesn't really make sense to implement this feature with also doing the same for ServicePulse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant