Incorrect BaseAddress formatting with RemoteInstance API paths that append a string to "/api" after the "http://{host}:{port}"

[TravisNickels]

Describe the bug

Description

When trying to use a different API path that contains the string "/api" the RemoteInstanceSetting constructor will replace the string "/api" with string.Empty, thus causing the BaseAddress to be formatted with an incorrect port address.

<configuration>
    <appSettings>
         <add key="ServiceControl/RemoteInstances" value="[{&quot;api_uri&quot;:&quot;http://localhost:9090/api_old/&quot;}]" />
    </appSettings>
</configuration>

Expected behavior

The BaseAddress should be set to "http://localhost:9090/

Actual behavior

The BaseAddress is set to "http://localhost:9090_old/", which produces an System.UriFormatException: Invalid URI: Invalid port specified error.

Versions

ServiceControl 5+

Steps to reproduce

• Install ServiceControl v5+
• Update the config file to have an API path that contains "/api" with a string appended that doesn't begin with "/" after the host and port for example: "http://localhost:9090/api_old/"
• The instance will throw an error: System.UriFormatException: Invalid URI: Invalid port specified

Relevant log output

Error|ServiceControl.CustomChecks.InternalCustomCheckManager|`ServiceControl.Operations.CheckRemotes` implementation failed to run.|System.UriFormatException: Invalid URI: Invalid port specified.

Additional Information

Workarounds

Don't append any string to "/api" in the URL after the host and port. Use different port numbers for remote instances instead different paths

example

• ❌ "http://localhost:9090/api_old/
• ✅ "http://localhost:9090/api/

Possible solutions

Convert the URL to an URI to isolate the different segments of the URL

Additional information

[boblangley]

We've reviewed this issue and added it to our backlog. It's eligible to be picked up for a future release, but we can't provide a firm timeline.