Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2.pas: SDL_AUDIO_ISLITTLEENDIAN stack overflow #138

Closed
Chixpy opened this issue Jun 10, 2024 · 2 comments
Closed

SDL2.pas: SDL_AUDIO_ISLITTLEENDIAN stack overflow #138

Chixpy opened this issue Jun 10, 2024 · 2 comments

Comments

@Chixpy
Copy link
Contributor

Chixpy commented Jun 10, 2024

Hello. I found another little mistake.

function SDL_AUDIO_ISLITTLEENDIAN(x: Cardinal): Cardinal;
begin
Result := not SDL_AUDIO_ISLITTLEENDIAN(x);
end;

It's calling itself recursively, when clearly we want to call SDL_AUDIO_ISBIGENDIAN

function SDL_AUDIO_ISLITTLEENDIAN(x: Cardinal): Cardinal;
begin
  Result := not SDL_AUDIO_ISBIGENDIAN(x);
end;

Can I make a fast PR to fix it?

@suve
Copy link
Collaborator

suve commented Jun 10, 2024

Oh oops. Well that's embarrassing.

Can I make a fast PR to fix it?

Sure. For small fixes like these, feel free to open a PR right away.

@suve
Copy link
Collaborator

suve commented Jun 10, 2024

Solved by PR #139. Thanks!

@suve suve closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants