Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curse limit is 1 more than expected #799

Open
3 tasks done
Blitz54 opened this issue Feb 17, 2025 · 3 comments · May be fixed by #815
Open
3 tasks done

Curse limit is 1 more than expected #799

Blitz54 opened this issue Feb 17, 2025 · 3 comments · May be fixed by #815
Labels
bug Something isn't working

Comments

@Blitz54
Copy link
Contributor

Blitz54 commented Feb 17, 2025

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

By default, player's have a curse limit of 1. It can be increased with the tree node Whispers of Doom.

What is the behaviour in Path of Building?

PoB2 seems to think the curse limit is 1 more than the player has. Applying 2 curses on an empty build, and applying 3 curses with Whispers of Doom allocated.

How to reproduce the issue

  1. Create new build
  2. Add 3 curse skills, the elemental ones are suggested.
  3. Check Calcs page, and see that 2 of them are applied to the Debuffs section.
  4. Take Whispers of Doom, and see that it now applies 3 curses to the enemy.

PoB for PoE2 build code

https://maxroll.gg/poe2/pob/0i97i0dh

Screenshots

Image

Image

@Blitz54
Copy link
Contributor Author

Blitz54 commented Feb 17, 2025

To add to this, if we add a Mark to the skills like Snipers Mark, it will also take priority over the second curse. PoE2 lets you curse and mark 1 enemy by default. So it seems to almost function properly, it just incorrectly allows the player to use 2 curses instead of a 1 curse and 1 mark.

@Paliak
Copy link
Contributor

Paliak commented Feb 17, 2025

@Blitz54 Current code doesn't differentiate between curse and mark pool. #119

Will need to split those since afaik those are seperate in POE2

@mauriliogenovese
Copy link
Contributor

There are already two different limits for curses and marks, but they are handled as a single limit when assigning available curse slots

@mauriliogenovese mauriliogenovese linked a pull request Feb 21, 2025 that will close this issue
@Blitz54 Blitz54 added the bug Something isn't working label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants