Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate shared battle loading states #641

Open
Paul-Ladyman opened this issue Jun 29, 2024 · 1 comment
Open

Consolidate shared battle loading states #641

Paul-Ladyman opened this issue Jun 29, 2024 · 1 comment

Comments

@Paul-Ladyman
Copy link
Owner

Currently a loading spinner is displayed when waiting for a battle to be shared. There is then a second loading state which displays "..." in the sub title whilst waiting for the player session link to be copied. This state should be removed and the loading spinner displayed until everything is ready or until an error occurs when a suitable error message should be displayed. This will probably require moving the copying of the link up from the sub title component to a higher level where it makes sense to activate the loading screen.

@Paul-Ladyman
Copy link
Owner Author

This will also resolve #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant