Skip to content

Commit ce1696b

Browse files
lemreyrlubos
authored andcommitted
treewide: do not select NRF_MODEM_LIB
libmodem is enabled automatically for all nRF9 projects. Using `select` to express a dependency is bad practice, and should be avoided in favour of `depends on`. Signed-off-by: Emanuele Di Santo <[email protected]>
1 parent 8c43742 commit ce1696b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

lib/modem_info/Kconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
menuconfig MODEM_INFO
88
bool "nRF91 modem information library"
9-
select NRF_MODEM_LIB
9+
depends on NRF_MODEM_LIB
1010
select AT_PARSER
1111
select AT_MONITOR
1212

lib/modem_jwt/Kconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
menuconfig MODEM_JWT
88
bool "Modem JWT Library"
9-
select NRF_MODEM_LIB
9+
depends on NRF_MODEM_LIB
1010
select BASE64
1111
help
1212
Functionality requires modem firmware version 1.3 or greater.

subsys/net/lib/nrf_cloud/Kconfig.nrf_cloud_fota

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ endif # NRF_CLOUD_REST
104104

105105
menuconfig NRF_CLOUD_FOTA_FULL_MODEM_UPDATE
106106
bool "Full modem FOTA updates"
107-
select NRF_MODEM_LIB
107+
depends on NRF_MODEM_LIB
108108
select ZCBOR
109109
select DFU_TARGET
110110
select DFU_TARGET_FULL_MODEM

0 commit comments

Comments
 (0)