Skip to content

Commit 8558809

Browse files
committed
Hide function prototyes from unauthorized callers
0351a62 extended hiding private functions from callers into the gcc world. Some functions are allowed only in extensions; so can not be marked as hidden; this commit discourages their use however, by hiding their prototypes to all but the core and extensions. It turns out that four functions were being used in modules we ship with that were marked as extensions-only; so they had to be made globally accessible.
1 parent d8c8b21 commit 8558809

File tree

3 files changed

+721
-612
lines changed

3 files changed

+721
-612
lines changed

embed.fnc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1312,7 +1312,7 @@ ERXp |SV * |get_prop_definition \
13121312
ERTXp |const char * const *|get_prop_values \
13131313
|const int table_index
13141314
: Used by SvRX and SvRXOK
1315-
EXopx |REGEXP *|get_re_arg |NULLOK SV *sv
1315+
Xopx |REGEXP *|get_re_arg |NULLOK SV *sv
13161316
AOdp |SV * |get_sv |NN const char *name \
13171317
|I32 flags
13181318
CRipx |MGVTBL *|get_vtbl |int vtbl_id
@@ -3694,9 +3694,9 @@ Cp |UV |_to_utf8_upper_flags \
36943694
|NULLOK STRLEN *lenp \
36953695
|bool flags
36963696

3697-
EXop |bool |try_amagic_bin |int method \
3697+
Xop |bool |try_amagic_bin |int method \
36983698
|int flags
3699-
EXop |bool |try_amagic_un |int method \
3699+
Xop |bool |try_amagic_un |int method \
37003700
|int flags
37013701
ARTdp |char * |uiv_2buf |NN char * const buf \
37023702
|const IV iv \
@@ -6303,7 +6303,7 @@ EXopx |OP * |pp_wrap |NN Perl_ppaddr_t real_pp_fn \
63036303
|I32 nargs \
63046304
|int nlists
63056305
Cpx |int |runops_wrap
6306-
EXopx |void |xs_wrap |NN XSUBADDR_t xsub \
6306+
Copx |void |xs_wrap |NN XSUBADDR_t xsub \
63076307
|NN CV *cv
63086308
#endif
63096309
#if defined(PERL_USE_3ARG_SIGHANDLER)

0 commit comments

Comments
 (0)