Perl_hv_common: sv_2mortal(newSVsv()) to sv_mortalcopy_flags()

richardleach · richardleach · commit 91c779a4e66d · 2025-03-31T14:19:00.000+01:00
diff --git a/hv.c b/hv.c
@@ -650,7 +650,7 @@ Perl_hv_common(pTHX_ HV *hv, SV *keysv, const char *key, STRLEN klen,
                     if (!keysv) {
                         keysv = newSVpvn_flags(key, klen, SVf_UTF8|SVs_TEMP);
                     } else {
-                        keysv = sv_2mortal(newSVsv(keysv));
+                        keysv = sv_mortalcopy_flags(keysv, SV_GMAGIC|SV_NOSTEAL);
                     }
                     mg_copy(MUTABLE_SV(hv), sv, (char *)keysv, HEf_SVKEY);
                 } else {

Original file line number	Diff line number	Diff line change
`@@ -650,7 +650,7 @@ Perl_hv_common(pTHX_ HV hv, SV keysv, const char *key, STRLEN klen,`
`650`	`650`	`if (!keysv) {`
`651`	`651`	`keysv = newSVpvn_flags(key, klen, SVf_UTF8\|SVs_TEMP);`
`652`	`652`	`} else {`
`653`		`- keysv = sv_2mortal(newSVsv(keysv));`
	`653`	`+ keysv = sv_mortalcopy_flags(keysv, SV_GMAGIC\|SV_NOSTEAL);`
`654`	`654`	`}`
`655`	`655`	`mg_copy(MUTABLE_SV(hv), sv, (char *)keysv, HEf_SVKEY);`
`656`	`656`	`} else {`