Skip to content

Commit bf6e580

Browse files
maukedemerphq
authored andcommitted
t/porting/header_parser.t: un-TODO warnings test
The absorbtion feature may not be implemented yet, but the current code doesn't throw any warnings either, so don't mark the "no warnings" test as TODO. This makes test runs a bit less noisy: Test Summary Report ------------------- porting/header_parser.t (Wstat: 0 Tests: 37 Failed: 0) TODO passed: 31
1 parent fc2306f commit bf6e580

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

t/porting/header_parser.t

+18-16
Original file line numberDiff line numberDiff line change
@@ -981,22 +981,24 @@ EOF_BLURB
981981
{
982982
my @warn;
983983
local $SIG{__WARN__}= sub { push @warn, $_[0]; warn $_[0] };
984-
local $::TODO;
985-
$::TODO= "Absorbtion not implemented yet";
986-
# currently we don't handle absorbtion: (A && (A || B || C ...)) == A
987-
my $hp= HeaderParser->new(debug=>0,add_commented_expr_after=>0);
988-
$hp->parse_text(<<~'EOF');
989-
#if defined(X) && (defined(X) || defined(Y))
990-
#define HAS_X
991-
#endif
992-
EOF
993-
my $grouped= $hp->group_content();
994-
my $as_text= $hp->lines_as_str($grouped);
995-
is($as_text,<<~'EOF',my $tname= "simplification by absorbtion"); # or show_text($as_text);
996-
#if defined(X)
997-
# define HAS_X
998-
#endif /* defined(X) */
999-
EOF
984+
my $tname = "simplification by absorbtion";
985+
{
986+
local $::TODO = "Absorbtion not implemented yet";
987+
# currently we don't handle absorbtion: (A && (A || B || C ...)) == A
988+
my $hp= HeaderParser->new(debug=>0,add_commented_expr_after=>0);
989+
$hp->parse_text(<<~'EOF');
990+
#if defined(X) && (defined(X) || defined(Y))
991+
#define HAS_X
992+
#endif
993+
EOF
994+
my $grouped= $hp->group_content();
995+
my $as_text= $hp->lines_as_str($grouped);
996+
is($as_text,<<~'EOF', $tname); # or show_text($as_text);
997+
#if defined(X)
998+
# define HAS_X
999+
#endif /* defined(X) */
1000+
EOF
1001+
}
10001002
is(join("\n",@warn),"", "No warnings generated from $tname");
10011003
}
10021004
{

0 commit comments

Comments
 (0)