Skip to content

[doc] Clarify the situation around smartmatch in perlexperiment #23272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
book opened this issue May 9, 2025 · 8 comments · Fixed by #23276
Closed

[doc] Clarify the situation around smartmatch in perlexperiment #23272

book opened this issue May 9, 2025 · 8 comments · Fixed by #23276

Comments

@book
Copy link
Contributor

book commented May 9, 2025

Where

pod/perlexperiment.pod

Description

The current document says about smartmatch:

Will be removed in 5.42.0

Since that was written, the smartmatch feature was created, and smartmatch was not removed, but disabled in the :5.42 feature bundle.

@Perl Perl deleted a comment May 10, 2025
@Perl Perl deleted a comment May 10, 2025
@Perl Perl deleted a comment May 10, 2025
@Perl Perl deleted a comment May 10, 2025
@jkeenan
Copy link
Contributor

jkeenan commented May 11, 2025

Where

pod/perlexperiment.pod

Description

The current document says about smartmatch:

Will be removed in 5.42.0

Since that was written, the smartmatch feature was created, and smartmatch was not removed, but disabled in the :5.42 feature bundle.

Can you point to the specific commits in which the disabling was implemented?

(I ask because there were so many smartmatch-related issues that I lost track of where things stand.)

Thanks.

@book
Copy link
Contributor Author

book commented May 11, 2025

#22752 requested that smartmatch was put behind a feature guard, instead of being completely removed. And it was implemented in #22766.

@jkeenan
Copy link
Contributor

jkeenan commented May 12, 2025

#22752 requested that smartmatch was put behind a feature guard, instead of being completely removed. And it was implemented in #22766.

When I go to #22766, I see that it was closed with 0 commits and 0 files changed. I don't understand that -- so I'll take a pass on writing a p.r. to satisfy this ticket. :(

@book
Copy link
Contributor Author

book commented May 12, 2025

I seems there was some kerfluffle around merging the PR. 15cbd20 is the commit that merged the smartmatch feature.

@tonycoz
Copy link
Contributor

tonycoz commented May 12, 2025

I looked at this and wondered how to describe it's status.

I don't think it's a current experiment, we're not planning on iterating on it's design for the same reason it wasn't removed.

I don't think it's "so wildly successful and played so well with others" that it belongs in Accepted features.

And it's no longer removed.

Add a new section "Developmental Backwaters" or "Features we tried to remove"?

@book
Copy link
Contributor Author

book commented May 12, 2025

Or "Failed Experiments that Stuck"?

@jkeenan
Copy link
Contributor

jkeenan commented May 12, 2025

Or "Failed Experiments that Stuck"?

Or perhaps "Discouraged", since placing it behind a feature guard is implicitly saying that something is not suitable for widespread use?

@tonycoz
Copy link
Contributor

tonycoz commented May 12, 2025

Or "Failed Experiments that Stuck"?

Missed the last "t" the first time I read that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants