Merge pull request facebookarchive#19 from facebook/philikon-cleanup

Cleanup: coding style and conventions

Author: philikon

Sample/.flowconfig

@@ -0,0 +1,46 @@
+[ignore]
+
+# We fork some components by platform.
+.*/*.web.js
+.*/*.android.js
+
+# Some modules have their own node_modules with overlap
+.*/node_modules/node-haste/.*
+
+# Ignore react-tools where there are overlaps, but don't ignore anything that
+# react-native relies on
+.*/node_modules/react-tools/src/React.js
+.*/node_modules/react-tools/src/renderers/shared/event/EventPropagators.js
+.*/node_modules/react-tools/src/renderers/shared/event/eventPlugins/ResponderEventPlugin.js
+.*/node_modules/react-tools/src/shared/vendor/core/ExecutionEnvironment.js
+
+
+# Ignore commoner tests
+.*/node_modules/commoner/test/.*
+
+# See https://github.com/facebook/flow/issues/442
+.*/react-tools/node_modules/commoner/lib/reader.js
+
+# Ignore jest
+.*/react-native/node_modules/jest-cli/.*
+
+[include]
+
+[libs]
+node_modules/react-native/Libraries/react-native/react-native-interface.js
+
+[options]
+module.system=haste
+
+munge_underscores=true
+
+suppress_type=$FlowIssue
+suppress_type=$FlowFixMe
+suppress_type=$FixMe
+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(1[0-4]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(1[0-4]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
+
+[version]
+0.14.0

react-native-fbsdkcore/FBSDKCore.ios.js

@@ -23,7 +23,7 @@
 'use strict';
 
 // Core modules
-exports.FBSDKAccessToken = require('./js-modules/FBSDKAccessToken.ios.js');
-exports.FBSDKAppEvents = require('./js-modules/FBSDKAppEvents.ios.js');
-exports.FBSDKGraphRequest = require('./js-modules/FBSDKGraphRequest.ios.js');
-exports.FBSDKGraphRequestManager = require('./js-modules/FBSDKGraphRequestManager.ios.js');
+exports.FBSDKAccessToken = require('./js/FBSDKAccessToken.ios.js');
+exports.FBSDKAppEvents = require('./js/FBSDKAppEvents.ios.js');
+exports.FBSDKGraphRequest = require('./js/FBSDKGraphRequest.ios.js');
+exports.FBSDKGraphRequestManager = require('./js/FBSDKGraphRequestManager.ios.js');

react-native-fbsdkcore/js-modules/FBSDKAppEvents.ios.js

@@ -17,7 +17,6 @@
 * IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 *
-* @providesModule FBSDKAccessToken
 * @flow
 */
 
@@ -35,31 +34,31 @@ type AccessTokenDict = {
   _refreshDate: number;
 };
 
-/*
+/**
  * Represents an immutable access token for using Facebook services.
  */
 class FBSDKAccessToken {
-  /*
+  /**
    * The opaque token string.
    */
   tokenString: string;
 
-  /*
+  /**
    * The known granted permissions.
    */
   permissions: Array<string>;
 
-  /*
+  /**
    * The known declined permissions.
    */
   declinedPermissions: Array<string>;
 
-  /*
+  /**
    * The app ID.
    */
   appID: string;
 
-  /*
+  /**
    * The user ID.
    */
   userID: string;
@@ -68,7 +67,7 @@ class FBSDKAccessToken {
   _expirationDate: number;
   _refreshDate: number;
 
-  /*
+  /**
    * Constructs a new FBSDKAccessToken object.
    */
   constructor(tokenDict: AccessTokenDict) {
@@ -83,50 +82,38 @@ class FBSDKAccessToken {
     Object.freeze(this);
   }
 
-  /*
+  /**
    * Gets the expiration date.
-   *
-   * @returns - Expiration date of the token.
    */
   getExpirationDate(): Date {
     return new Date(this._expirationDate);
   }
 
-  /*
+  /**
    * Gets the the date the token was last refreshed.
-   *
-   * @returns - Refresh date of the token.
    */
   getRefreshDate(): Date {
     return new Date(this._refreshDate);
   }
 
-  /*
+  /**
    * Indicates whether the specified permission has been granted.
-   *
-   * @param (string) permission - The permissions to check the status of.
-   *
-   * @returns - true if permission has been granted, otherwise false
    */
   hasGrantedPermission(permission: string): boolean {
     return this.permissions.some((perm) => perm === permission);
   }
 
-  /*
+  /**
    * Makes a request to retrieve the current access token.
-   *
-   * @param ((token: FBSDKAccessToken) => void) callback - Called with the current access token.
    */
   static getCurrentAccessToken(callback: (token: ?FBSDKAccessToken) => void) {
     FBSDKAccessTokenInterface.getCurrentAccessToken((tokenDict) => {
       callback(tokenDict ? new FBSDKAccessToken(tokenDict) : null);
     });
   }
 
-  /*
+  /**
    * Sets the current access token to the one provided.
-   *
-   * @param (FBSDKAccessToken) token  - An access token.
    */
   static setCurrentAccessToken(token: FBSDKAccessToken) {
     FBSDKAccessTokenInterface.setCurrentAccessToken(token);

react-native-fbsdkcore/js-modules/FBSDKAccessToken.ios.js react-native-fbsdkcore/js/FBSDKAccessToken.ios.js

@@ -0,0 +1,89 @@
+/**
+* Copyright (c) 2015-present, Facebook, Inc. All rights reserved.
+*
+* You are hereby granted a non-exclusive, worldwide, royalty-free license to use,
+* copy, modify, and distribute this software in source code or binary form for use
+* in connection with the web services and APIs provided by Facebook.
+*
+* As with any software that integrates with the Facebook platform, your use of
+* this software is subject to the Facebook Developer Principles and Policies
+* [http://developers.facebook.com/policy/]. This copyright notice shall be
+* included in all copies or substantial portions of the software.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+*
+* @flow
+*/
+
+'use strict';
+
+var FBSDKAppEventsInterface = require('react-native').NativeModules.FBSDKAppEvents;
+var FBSDKAccessToken = require('./FBSDKAccessToken.ios.js');
+
+/**
+ * Specifies when events are sent to the server.
+ */
+type FBSDKAppEventsFlushBehavior = 'auto' | 'explicity-only';
+
+module.exports = {
+  /**
+   * Logs an event.
+   */
+  logEvent(
+    eventName: string,
+    valueToSum: ?number,
+    parameters: ?Object,
+    accessToken: ?FBSDKAccessToken
+  ) {
+    FBSDKAppEventsInterface.logEvent(
+      eventName,
+      valueToSum,
+      parameters,
+      accessToken
+    );
+  },
+
+  /**
+   * Logs a purchase.
+   */
+  logPurchase(
+    purchaseAmount: number,
+    currency: string,
+    parameters: ?Object,
+    accessToken: ?FBSDKAccessToken
+  ) {
+    FBSDKAppEventsInterface.logPurchase(
+      purchaseAmount,
+      currency,
+      parameters,
+      accessToken
+    );
+  },
+
+  /**
+   * Sets the current event flushing behavior specifying when events
+   * are sent back to Facebook servers.
+   */
+  setFlushBehavior(flushBehavior: FBSDKAppEventsFlushBehavior) {
+    FBSDKAppEventsInterface.setFlushBehavior(flushBehavior);
+  },
+
+  /**
+   * Sets the override app ID for app event logging.
+   */
+  setLoggingOverrideAppID(appID: string) {
+    FBSDKAppEventsInterface.setLoggingOverrideAppID(appID);
+  },
+
+  /**
+   * Explicitly kicks off flushing of events to Facebook.
+   */
+  flush() {
+    FBSDKAppEventsInterface.flush();
+  },
+};