Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking app #2

Closed
dapearce opened this issue May 26, 2015 · 9 comments
Closed

Breaking app #2

dapearce opened this issue May 26, 2015 · 9 comments

Comments

@dapearce
Copy link

Hi Philipp, your demo looks great. I just ported to Flow Router today and love it so far. Unfortunately, when I add this package it immediately breaks my app, before I even try to implement anything. Any idea what I might be missing?

screen shot 2015-05-26 at 3 22 22 pm

@PhilippSpo
Copy link
Owner

This error was due to the Flow-Router update to version 1.9.0, which changed the way you can get the route name.
Should be fixed now. Just update the momentum-flow-router package to 0.0.3
36411de

@PhilippSpo
Copy link
Owner

There is still some weirdness happening when changing routes.. seems to apply the wrong transition sometimes.. i'll look into it real quick

@PhilippSpo PhilippSpo reopened this May 26, 2015
@PhilippSpo
Copy link
Owner

Alright back to normal again :)
Now the package is using Flow-Router 1.9.0 and working as usual.
The demo is also updated and deployed.
Please update to version 0.0.4 of momentum-flow-router

@dapearce
Copy link
Author

Thanks for the quick response. I updated and it fixed the errors. Unfortunately I'm having some trouble implementing in my app, but I'm guessing it's just confusion on my part. Is it possible to use this between different flow layouts? Or does it have to be the same layout?

@PhilippSpo
Copy link
Owner

Yes switching layouts is a problem, since the html nodes that change are not wrapped inside the momentum helper anymore..

@PhilippSpo
Copy link
Owner

So I did some research and it turns out, that momentum uses Meteors _uihooks in order to perform animations once a DOM node gets inserted. These uihooks only work for nodes, that get manipulated by Blaze, not nodes that you insert manually using jQuery or normal javascript. This is problematic since FlowLayout uses jQuery to render a new Layout to the DOM. And this is probably what would need to change in order to get this working...

@PhilippSpo
Copy link
Owner

worked on the flow-layout package and got it working:
http://flow-layout-transitions.meteor.com/
Made a Pull Request on the FlowLayout for this.. If that gets merged we'll have layout transitions :)

@arunoda
Copy link

arunoda commented May 30, 2015

Hey, would you mind sharing the code for http://flow-layout-transitions.meteor.com/. I'd like to support it. But somehow I don't like the way you done it in the PR.

@PhilippSpo
Copy link
Owner

The Code is here: https://github.com/PhilippSpo/momentum-flow-router-demo/tree/flow-layout-transitions
I would be glad to reason about and improve the code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants