Skip to content

Update PhotonClient to use Vue@3 #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
srimanachanta opened this issue Jul 9, 2023 · 3 comments · May be fixed by #1900
Open

Update PhotonClient to use Vue@3 #885

srimanachanta opened this issue Jul 9, 2023 · 3 comments · May be fixed by #1900
Labels
frontend Having to do with PhotonClient and its related items

Comments

@srimanachanta
Copy link
Member

Currently, PhotonVision uses Vue2.7 (following #767), a middle ground between Vue2 and Vue3 that helps devs quickly transfer between versions. The main issue is that Vue2.7 misses some features and has annoying quirks that worsen the entire development experience (Custom Vite plugins, intermediate docs / no docs for things, etc.). Much of the work required for this wap is handled by #884 (Updating everything to the Composition API and using many of the new Vue3 APIs. This process should be completed with a complete update to Vue3 and Vuetify3 along with other peer dependencies.
@srimanachanta srimanachanta added the frontend Having to do with PhotonClient and its related items label Jul 9, 2023
@srimanachanta
Copy link
Member Author

Stalled by #884

@srimanachanta
Copy link
Member Author

Also reimplement vue-tsc as all issues pertaining to it should be resolved upon updating Vue to v3 and the rest of the required APIs

@srimanachanta srimanachanta changed the title Update to Vue3 and Vuetify3 Update to PhotonClient to use Vue@3 Jul 19, 2023
@srimanachanta srimanachanta changed the title Update to PhotonClient to use Vue@3 Update PhotonClient to use Vue@3 Jul 19, 2023
@srimanachanta
Copy link
Member Author

srimanachanta commented Oct 11, 2023 •
edited
Loading

All photon-client common input fields should be updated to use generic types for the values. This would fix many of the typing errors that TS can't pick up on. Types can also now use imported types so we can utilize those for the app component props

@Gold856 Gold856 mentioned this issue Apr 11, 2025
Open
6 tasks
@GrahamSH-LLK GrahamSH-LLK linked a pull request Apr 15, 2025 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Having to do with PhotonClient and its related items
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vue 3 Upgrade GrahamSH-LLK/photonvision
1 participant
@srimanachanta