Skip to content

Commit 4aa5d0d

Browse files
committed
Add CMake dependency and use smart pointers for class definitions
1 parent c4be47b commit 4aa5d0d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ find_package(ament_cmake_python REQUIRED)
66
find_package(rclcpp REQUIRED)
77
find_package(geometry_msgs REQUIRED)
88
find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
9+
find_package(picknik_pybind11 REQUIRED)
910
find_package(pybind11 3.0 REQUIRED)
1011

1112
add_library(${PROJECT_NAME} SHARED

src/rclcpp.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ PYBIND11_MODULE(rclcpp, m)
8282
m.def("shutdown", &shutdown, "Shutdown rclcpp");
8383

8484
using Class = rclcpp::NodeOptions;
85-
py::class_<Class>(m, "NodeOptions")
85+
py::classh<Class>(m, "NodeOptions")
8686
.def(InitFromKwargs<Class>())
8787
.def_property(
8888
"arguments", [](const Class& self) { return self.arguments(); },
@@ -110,7 +110,7 @@ PYBIND11_MODULE(rclcpp, m)
110110
[](const Class& self) { return self.automatically_declare_parameters_from_overrides(); },
111111
[](Class* self, bool value) { self->automatically_declare_parameters_from_overrides(value); });
112112

113-
py::class_<rclcpp::Node, rclcpp::Node::SharedPtr>(m, "Node")
113+
py::classh<rclcpp::Node>(m, "Node")
114114
.def(py::init([](const std::string& name, const rclcpp::NodeOptions& opts) {
115115
auto node = std::make_shared<rclcpp::Node>(name, opts);
116116
add_node(node);

0 commit comments

Comments
 (0)