Merge pull request #1623 from theovilardo/optim/app-general-optimization-1

This commit introduces major database optimizations and UI performanc…

Author: theovilardo

app/schemas/com.theveloper.pixelplay.data.database.PixelPlayDatabase/35.json

@@ -26,6 +26,7 @@ class MusicDaoTest {
     fun createDb() {
         val context = ApplicationProvider.getApplicationContext<Context>()
         db = Room.inMemoryDatabaseBuilder(context, PixelPlayDatabase::class.java)
+            .addCallback(PixelPlayDatabase.createRuntimeArtifactsCallback())
             .allowMainThreadQueries() // Permite consultas en el hilo principal para tests
             .build()
         musicDao = db.musicDao()

app/schemas/com.theveloper.pixelplay.data.database.PixelPlayDatabase/36.json

@@ -17,22 +17,23 @@ class PixelPlayDatabaseMigrationTest {
     @get:Rule
     val helper = MigrationTestHelper(
         InstrumentationRegistry.getInstrumentation(),
-        PixelPlayDatabase::class.java.canonicalName,
+        requireNotNull(PixelPlayDatabase::class.java.canonicalName),
         FrameworkSQLiteOpenHelperFactory()
     )
 
     @After
     fun tearDown() {
         val context = InstrumentationRegistry.getInstrumentation().targetContext
-        for (version in 25..33) {
+        for (version in 25..35) {
             context.deleteDatabase(databaseNameFor(version))
         }
         context.deleteDatabase(DB_NAME_33_TO_34)
+        context.deleteDatabase(DB_NAME_35_TO_36)
     }
 
     @Test
     fun migrateEveryExportedSchemaToLatest() {
-        for (startVersion in 25..33) {
+        for (startVersion in 25..35) {
             helper.createDatabase(databaseNameFor(startVersion), startVersion).close()
 
             helper.runMigrationsAndValidate(
@@ -50,7 +51,7 @@ class PixelPlayDatabaseMigrationTest {
 
         helper.runMigrationsAndValidate(
             DB_NAME_33_TO_34,
-            PixelPlayDatabaseVersion.LATEST,
+            34,
             true,
             PixelPlayDatabase.MIGRATION_33_34
         ).let { db ->
@@ -78,14 +79,36 @@ class PixelPlayDatabaseMigrationTest {
         }
     }
 
+    @Test
+    fun migration35To36AddsSongsFtsTable() {
+        helper.createDatabase(DB_NAME_35_TO_36, 35).close()
+
+        helper.runMigrationsAndValidate(
+            DB_NAME_35_TO_36,
+            36,
+            true,
+            PixelPlayDatabase.MIGRATION_35_36
+        ).let { db ->
+            val cursor = db.query("SELECT name FROM sqlite_master WHERE type = 'table' AND name = 'songs_fts'")
+            try {
+                assertTrue(cursor.moveToFirst())
+                assertEquals("songs_fts", cursor.getString(0))
+            } finally {
+                cursor.close()
+                db.close()
+            }
+        }
+    }
+
     private fun databaseNameFor(startVersion: Int): String = "migration-test-$startVersion"
 
     private object PixelPlayDatabaseVersion {
-        const val LATEST = 34
+        const val LATEST = 36
     }
 
     companion object {
         private const val DB_NAME_33_TO_34 = "migration-test-33-to-34"
+        private const val DB_NAME_35_TO_36 = "migration-test-35-to-36"
 
         private val ALL_MIGRATIONS = arrayOf(
             PixelPlayDatabase.MIGRATION_25_26,
@@ -96,7 +119,9 @@ class PixelPlayDatabaseMigrationTest {
             PixelPlayDatabase.MIGRATION_30_31,
             PixelPlayDatabase.MIGRATION_31_32,
             PixelPlayDatabase.MIGRATION_32_33,
-            PixelPlayDatabase.MIGRATION_33_34
+            PixelPlayDatabase.MIGRATION_33_34,
+            PixelPlayDatabase.MIGRATION_34_35,
+            PixelPlayDatabase.MIGRATION_35_36
         )
     }
 }

app/src/androidTest/java/com/theveloper/pixelplay/data/database/MusicDaoTest.kt

@@ -70,6 +70,7 @@ class SyncWorkerTest {
     fun setUp() {
         context = ApplicationProvider.getApplicationContext()
         database = Room.inMemoryDatabaseBuilder(context, PixelPlayDatabase::class.java)
+            .addCallback(PixelPlayDatabase.createRuntimeArtifactsCallback())
             .allowMainThreadQueries() // Para tests, está bien.
             .build()
         musicDao = database.musicDao()