fix(transport/http): remove @tls instance variable

Author: stakach

shard.yml

@@ -1,5 +1,5 @@
 name: placeos-driver
-version: 7.7.0
+version: 7.7.1
 
 dependencies:
   action-controller:

src/placeos-driver/interface/sensor.cr

@@ -178,7 +178,7 @@ abstract class PlaceOS::Driver
         def convert_measurement_to(other_unit : String)
           this_unit = self.unit
           return self.value unless this_unit
-  
+
           Units::Measurement.new(self.value, this_unit).convert_to(other_unit).to_f
         end
       end

src/placeos-driver/transport/http.cr

@@ -120,7 +120,6 @@ class PlaceOS::Driver
       &@received : -> Nil
     )
       @terminated = false
-      @tls = new_tls_context
       @uri_base = URI.parse(@uri)
       @ip = @uri_base.hostname.not_nil!
       @http_client_mutex = Mutex.new
@@ -134,12 +133,11 @@ class PlaceOS::Driver
       @client_idle = Time.monotonic
       @client_requests = 0
 
-      context = __is_https? ? @tls : nil
+      context = __is_https? ? new_tls_context : nil
       @client = new_http_client(@uri_base, context)
     end
 
     @params_base : URI::Params
-    @tls : OpenSSL::SSL::Context::Client
     @client : ConnectProxy::HTTPClient
     @client_idle : Time::Span
     @keep_alive : Time::Span
@@ -158,22 +156,22 @@ class PlaceOS::Driver
       @queue.online = true
     end
 
-    def start_tls(verify_mode = OpenSSL::SSL::VerifyMode::NONE, context = @tls) : Nil
-      tls = context || OpenSSL::SSL::Context::Client.new
-      tls.verify_mode = verify_mode
-      @tls = tls
+    def start_tls(verify_mode : OpenSSL::SSL::VerifyMode, context : OpenSSL::SSL::Context = new_tls_context) : Nil
+      context.verify_mode = verify_mode
 
       # Re-create the client with the new TLS configuration
-      @client = new_http_client(@uri_base, @tls)
+      @http_client_mutex.synchronize do
+        @client = new_http_client(@uri_base, context)
+        @client_requests = 0
+      end
     end
 
     protected def __is_https?
       (@uri_base.scheme || "http").ends_with?('s')
     end
 
     protected def __new_http_client
-      @tls = new_tls_context
-      context = __is_https? ? @tls : nil
+      context = __is_https? ? new_tls_context : nil
 
       begin
         @client.try &.close
@@ -262,7 +260,10 @@ class PlaceOS::Driver
                    # Does this request require a TLS context?
                    context = __is_https? ? new_tls_context : nil
                    client = new_http_client(uri, context)
-                   client.exec(method.to_s.upcase, uri.request_target, headers, body).tap { client.close }
+                   client.exec(method.to_s.upcase, uri.request_target, headers, body).tap do
+                     client.close
+                     context = nil
+                   end
                  else
                    # Only a single request can occur at a time
                    # crystal does not provide any queuing mechanism so this mutex does the trick