fix(transport): split the requirement for both private and client certs

Author: stakach

shard.yml

@@ -1,5 +1,5 @@
 name: placeos-driver
-version: 7.11.7
+version: 7.11.8
 
 dependencies:
   action-controller:

src/placeos-driver/transport.cr

@@ -237,39 +237,57 @@ abstract class PlaceOS::Driver::Transport
     end
 
     # allow for certificate based authentication
-    if configure_client_certificates
+    if configure_private_key
       tls.private_key = private_key_file
+    end
+
+    if configure_client_certificate
       tls.certificate_chain = client_cert_file
     end
 
     tls
   end
 
-  protected def configure_client_certificates : Bool
-    if (private_key = @settings.get { setting?(String, :https_private_key).presence }) &&
-       (client_cert = @settings.get { setting?(String, :https_client_cert).presence })
+  protected def configure_private_key : Bool
+    if (private_key = @settings.get { setting?(String, :https_private_key).presence })
       key_contents = begin
         File.read(private_key_file)
       rescue error
         logger.debug { "will write private key" }
         ""
       end
 
+      if private_key != key_contents
+        File.write(private_key_file, private_key)
+      end
+      true
+    else
+      false
+    end
+  rescue error
+    logger.error(exception: error) { "issue configuring TLS private key" }
+    false
+  end
+
+  protected def configure_client_certificate : Bool
+    if (client_cert = @settings.get { setting?(String, :https_client_cert).presence })
       cer_contents = begin
         File.read(client_cert_file)
       rescue error
         logger.debug { "will write client certificate" }
         ""
       end
 
-      if private_key != key_contents || cer_contents != client_cert
-        File.write(private_key_file, private_key)
+      if cer_contents != client_cert
         File.write(client_cert_file, client_cert)
       end
       true
     else
       false
     end
+  rescue error
+    logger.error(exception: error) { "issue configuring TLS client certificate" }
+    false
   end
 
   private def process(data : Bytes) : Nil