Skip to content

Commit dd3edae

Browse files
committed
fix(bacnet): improved handling of NaN values
1 parent 5ae7055 commit dd3edae

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

drivers/ashrae/bacnet.cr

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,10 @@ class Ashrae::BACnet < PlaceOS::Driver
170170
val.property_type
171171
in ::BACnet::ObjectIdentifier
172172
{val.object_type, val.instance_number}
173-
in Nil, Bool, UInt64, Int64, Float32, Float64, String
173+
in Nil, Bool, UInt64, Int64, String
174174
val
175+
in Float32, Float64
176+
val.nan? ? nil : val
175177
end
176178
rescue
177179
nil
@@ -555,9 +557,7 @@ class Ashrae::BACnet < PlaceOS::Driver
555557
in Bool
556558
obj_value ? 1.0 : 0.0
557559
in UInt64, Int64, Float32, Float64
558-
float = obj_value.to_f64
559-
return nil if float.nan?
560-
float
560+
obj_value.to_f64
561561
end
562562
return nil if value.nil?
563563

drivers/ashrae/bacnet_secure_connect.cr

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,10 @@ class Ashrae::BACnetSecureConnect < PlaceOS::Driver
138138
val.property_type
139139
in ::BACnet::ObjectIdentifier
140140
{val.object_type, val.instance_number}
141-
in Nil, Bool, UInt64, Int64, Float32, Float64, String
141+
in Nil, Bool, UInt64, Int64, String
142142
val
143+
in Float32, Float64
144+
val.nan? ? nil : val
143145
end
144146
rescue
145147
nil
@@ -510,9 +512,7 @@ class Ashrae::BACnetSecureConnect < PlaceOS::Driver
510512
in Bool
511513
obj_value ? 1.0 : 0.0
512514
in UInt64, Int64, Float32, Float64
513-
float = obj_value.to_f64
514-
return nil if float.nan?
515-
float
515+
obj_value.to_f64
516516
end
517517
return nil if value.nil?
518518

0 commit comments

Comments
 (0)