fix: specs

Author: stakach

OPENAPI_DOC.yml

@@ -15750,6 +15750,75 @@ paths:
             application/json:
               schema:
                 $ref: '#/components/schemas/PlaceOS__Api__Application__ContentError'
+  /api/engine/v2/signage/playlists/{id}/approve:
+    post:
+      summary: approve a playlist for publication on displays
+      tags:
+      - Playlist
+      operationId: PlaceOS::Api::Playlist_approve_media
+      parameters:
+      - name: id
+        in: path
+        required: true
+        schema:
+          type: string
+      responses:
+        200:
+          description: OK
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Bool'
+        409:
+          description: Conflict
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/PlaceOS__Api__Application__CommonError'
+        401:
+          description: Unauthorized
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/PlaceOS__Api__Application__CommonError'
+        403:
+          description: Forbidden
+        404:
+          description: Not Found
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/PlaceOS__Api__Application__CommonError'
+        408:
+          description: Request Timeout
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/PlaceOS__Api__Application__CommonError'
+        400:
+          description: Bad Request
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/PlaceOS__Api__Application__ParameterError'
+        422:
+          description: Unprocessable Entity
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/PlaceOS__Api__Application__ParameterError'
+        406:
+          description: Not Acceptable
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/PlaceOS__Api__Application__ContentError'
+        415:
+          description: Unsupported Media Type
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/PlaceOS__Api__Application__ContentError'
   /api/engine/v2/signage/playlists/{id}/media:
     get:
       summary: get the current list of media for the playlist
@@ -21240,6 +21309,10 @@ components:
               type: integer
               format: Int64
               nullable: true
+            logged_out_at:
+              type: string
+              format: date-time
+              nullable: true
             work_preferences:
               type: array
               items:
@@ -22484,6 +22557,13 @@ components:
         makebreak:
           type: boolean
           nullable: true
+        analytics_enabled:
+          type: boolean
+          nullable: true
+        analytics_interval_minutes:
+          type: integer
+          format: Int32
+          nullable: true
         uri:
           type: string
           nullable: true
@@ -23362,6 +23442,13 @@ components:
               makebreak:
                 type: boolean
                 nullable: true
+              analytics_enabled:
+                type: boolean
+                nullable: true
+              analytics_interval_minutes:
+                type: integer
+                format: Int32
+                nullable: true
               uri:
                 type: string
                 nullable: true
@@ -25327,6 +25414,19 @@ components:
         user_name:
           type: string
           nullable: true
+        approved:
+          type: boolean
+          nullable: true
+        approved_by_id:
+          type: string
+          nullable: true
+        approved_by_name:
+          type: string
+          nullable: true
+        approved_by_email:
+          type: string
+          format: email
+          nullable: true
         items:
           type: array
           items:
@@ -25793,6 +25893,13 @@ components:
               makebreak:
                 type: boolean
                 nullable: true
+              analytics_enabled:
+                type: boolean
+                nullable: true
+              analytics_interval_minutes:
+                type: integer
+                format: Int32
+                nullable: true
               uri:
                 type: string
                 nullable: true
@@ -27923,6 +28030,10 @@ components:
           type: integer
           format: Int64
           nullable: true
+        logged_out_at:
+          type: string
+          format: date-time
+          nullable: true
         work_preferences:
           type: array
           items:
@@ -28506,6 +28617,13 @@ components:
                   makebreak:
                     type: boolean
                     nullable: true
+                  analytics_enabled:
+                    type: boolean
+                    nullable: true
+                  analytics_interval_minutes:
+                    type: integer
+                    format: Int32
+                    nullable: true
                   uri:
                     type: string
                     nullable: true

spec/controllers/signage_spec.cr

@@ -109,7 +109,7 @@ module PlaceOS::Api
         item2.play_count.should eq 2
       end
 
-      it "can approve digital signage playlists" do
+      it "can approve digital signage playlists", focus: true do
         revision = Model::Generator.revision
 
         item = Model::Generator.item
@@ -143,6 +143,9 @@ module PlaceOS::Api
         json["playlist_config"][playlist_id][0]["id"].should eq playlist_id
         json["playlist_config"][playlist_id][1].should eq [] of String
 
+        # skip forward a moment to avoid a 304
+        sleep 1
+
         # we should now approve the playlist
         approved = client.post(
           path: "#{Signage.base_route}/playlists/#{playlist_id}/approve",
@@ -156,6 +159,8 @@ module PlaceOS::Api
         revision.approved.should be_true
         revision.updated_at.should_not eq updated_at
 
+        system.playlists_last_updated.should eq revision.updated_at
+
         # the route should have modified
         headers["If-Modified-Since"] = result.headers["Last-Modified"]
         result = client.get(