Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement caption and meta-information for images #119

Open
tammoterhark opened this issue Nov 26, 2018 · 2 comments · May be fixed by #344
Open

implement caption and meta-information for images #119

tammoterhark opened this issue Nov 26, 2018 · 2 comments · May be fixed by #344
Labels
Level: Easy Under 4 hours of work Value: Coders Enhancement of codebase, API, documentation Value: Users Improve user experience, add new features Value: Visitors Improve navigation, styling

Comments

@tammoterhark
Copy link
Contributor

tammoterhark commented Nov 26, 2018

title, attribution; store in title and longdesc attributes; display as figure with figcaption elements

autofill attribution from exif information

step 1) update WYMeditor image dialog with "attribution"
step 2) save attribution as longdesc attribute at the image
step 3) create and add figcaption element from longdesc attribute
step 4) set "cc: author (date)" as placeholder for "attribution"
step 5) read exif data to autofill "attribution"

@tammoterhark tammoterhark added Level: Easy Under 4 hours of work Value: Coders Enhancement of codebase, API, documentation Value: Users Improve user experience, add new features Value: Visitors Improve navigation, styling labels Nov 26, 2018
@giplt giplt mentioned this issue Nov 26, 2018
@matthijskooijman
Copy link
Contributor

@laurensmartina implemented this in #344, but we discovered that the longdesc attribute is supposed to contain a URL pointing to a description of the image (similar to the alt attribute, but longer). See https://www.w3.org/TR/html-longdesc/#UCnR

So using longdesc here is not quite ideal. There does not seem to be an HTML standard attribute for attribution/copyright/license, so maybe just data-attribution would be better.

As for displaying it, I wonder if displaying the attribution info as a caption makes sense, I'd be more inclined to show the title tag as a caption maybe. Looking around, it seems the <small> tag (meant for the "small print" in HTML5) might be a better fit, see: https://stackoverflow.com/a/21489636/740048

@matthijskooijman
Copy link
Contributor

Additional improvements (as indirectly suggested in the Stadsbron marketing advice) would be to offer more guidance to the users about alt tags, to encourage them to enter a meaningful alt tag (probably also stop autofilling the alt tag with the filename).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: Easy Under 4 hours of work Value: Coders Enhancement of codebase, API, documentation Value: Users Improve user experience, add new features Value: Visitors Improve navigation, styling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants