Fixes #68: translation support on frozen apps (Windows)

Author: PierreRaybaut

CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog #
 
+## Version 3.2.2 ##
+
+🛠️ Bug fixes:
+
+* Fixed translation support (`gettext`):
+  * Locale detection has been fixed in 3.1.1 (deprecation of `locale.getdefaultlocale`)
+  * However, on frozen distributions on Windows (e.g. with `pyinstaller`), function
+    `locale.getlocale` is returning `(None, None)` instead of proper locale infos
+  * Added a workaround: on Windows, if locale can't be detected, we now use the
+    Windows API to retrieve it (using the `GetUserDefaultLocaleName` function)
+  * [Issue #68](https://github.com/PlotPyStack/guidata/issues/68) - Windows: gettext translation is not working on frozen applications
+
 ## Version 3.2.1 ##
 
 🛠️ Bug fixes:

guidata/__init__.py

@@ -8,7 +8,7 @@
 and application development tools for Qt.
 """
 
-__version__ = "3.2.1"
+__version__ = "3.2.2"
 
 
 # Dear (Debian, RPM, ...) package makers, please feel free to customize the

guidata/configtools.py

@@ -43,7 +43,7 @@
 from collections.abc import Callable
 from typing import TYPE_CHECKING
 
-from guidata.utils.misc import decode_fs_string, get_module_path
+from guidata.utils.misc import decode_fs_string, get_module_path, get_system_lang
 
 if TYPE_CHECKING:  # pragma: no cover
     from qtpy import QtCore as QC
@@ -93,9 +93,7 @@ def get_translation(modname: str, dirname: str | None = None) -> Callable[[str],
         dirname = modname
     # fixup environment var LANG in case it's unknown
     if "LANG" not in os.environ:
-        import locale  # Warning: 2to3 false alarm ('import' fixer)
-
-        lang = locale.getlocale()[0]
+        lang = get_system_lang()
         if lang is not None:
             os.environ["LANG"] = lang
     try:
@@ -459,3 +457,4 @@ def get_brush(
     alpha = conf.get(section, option + "/alphaF", alpha)
     color.setAlphaF(alpha)
     return QG.QBrush(color)
+    return QG.QBrush(color)

guidata/utils/misc.py

@@ -29,7 +29,8 @@
 from __future__ import annotations
 
 import collections.abc
-import locale  # Warning: 2to3 false alarm ('import' fixer)
+import ctypes
+import locale
 import os
 import os.path as osp
 import subprocess
@@ -40,7 +41,7 @@
 from guidata.userconfig import get_home_dir
 
 # ==============================================================================
-# Strings
+# Strings, Locale
 # ==============================================================================
 
 
@@ -79,6 +80,31 @@ def decode_fs_string(string: str) -> str:
     return string.decode(charset)
 
 
+def get_system_lang() -> str | None:
+    """
+    Retrieves the system language name.
+
+    This function uses `locale.getlocale()` to obtain the locale name based on
+    the current user's settings. If that fails on Windows (e.g. for frozen
+    applications), it uses the Win32 API function `GetUserDefaultLocaleName`
+    to obtain the locale name.
+
+    Returns:
+        The locale name in a format like 'en_US', or None if the function fails
+        to retrieve the locale name.
+    """
+    lang = locale.getlocale()[0]
+    if lang is None and os.name == "nt":
+        kernel32 = ctypes.WinDLL("kernel32", use_last_error=True)
+        GetUserDefaultLocaleName = kernel32.GetUserDefaultLocaleName
+        GetUserDefaultLocaleName.argtypes = [ctypes.c_wchar_p, ctypes.c_int]
+        GetUserDefaultLocaleName.restype = ctypes.c_int
+        locale_name = ctypes.create_unicode_buffer(85)
+        if GetUserDefaultLocaleName(locale_name, 85):
+            lang = locale_name.value.replace("-", "_")
+    return lang
+
+
 # ==============================================================================
 # Interface checking
 # ==============================================================================
@@ -355,3 +381,4 @@ def convert_date_format(format_string: str) -> str:
             i += 1
 
     return qt_format
+    return qt_format