[1.20.1] Surface Pokemobs spawn in caves

[supdogpsi]

(I'm unsure if 1.20 is still maintained. This old bug is still around, though, and I couldn't find it here, so I'm documenting it. Feel free to close if I'm being redundant!)

Issue Description:

Elevation/caves is not properly accounted for when spawning Pokemobs. This causes surface mobs to spawn in caves, even at very low Y levels.
I personally encountered this issue while using More Villagers and Flat Bedrock worldgen mods, but other times I've heard of this bug supposedly occurring even without said mods. Maybe both should be tested.

What happens:

Various areas that should count as caves (deep underground, even at deepslate level) do not, causing them to use the surface spawning pool. This causes Pokemobs you'd expect on the surface to spawn underground.

This bug is even visible with the Pokewatch - you will see that the areas do not count as caves.

What you expected to happen:

Cave Pokemobs like Geodude, Zubat, etc. to spawn in underground areas.

Steps to reproduce:

1. Open up a world
2. Explore caves
3. Eventually, you're bound to find surface Pokemob spawns like Pidgey/Rattata, even when at deepslate level
   ...

---

Affected Versions (Do not use "latest"): Replace with a list of all mods you have in.

• Pokecube AIO: pokecube-aio-1.20.1-3.25.1
• Minecraft: 1.20.1
• Forge: 47.4.10

[Unoriginally]

The bug was fixed in 1.21.1, I remember raising the same issue on the discord a few months ago.