Add a "custom" test fixture to manually add coverage for specific cases.

This means we can't delete the entire fixtures directory for test setup,
so instead check each repo individually, and get rid of the now useless
"test:setup-once" script.

Also fix a race condition between emptying the goldens directory and
generating new goldens. Turns up now because the custom fixture is so
fast to process.

Author: aomarks

.gitignore

@@ -1,3 +1,6 @@
 /node_modules
 /lib
-/src/test/fixtures
+
+# All of the test fixtures are generated on install, except for "custom".
+/src/test/fixtures/*
+!/src/test/fixtures/custom

package-lock.json

@@ -39,10 +39,9 @@
     "format": "find src -name '*.ts' -not -path 'src/test/fixtures/*' -not -path 'src/test/goldens/*' | xargs clang-format --style=file -i",
     "build": "npm run clean && tsc",
     "build:watch": "tsc --watch",
-    "test": "npm run test:setup-once && npm run build && mocha",
+    "test": "npm run test:setup && npm run build && mocha",
     "test:watch": "watchy -w src -- npm run test",
     "test:setup": "scripts/setup-fixtures.sh",
-    "test:setup-once": "mkdir src/test/fixtures && npm run test:setup || true",
     "test:make-goldens": "npm run build && scripts/make-goldens.js"
   },
   "repository": {

package.json

@@ -28,7 +28,7 @@ const {generateDeclarations} = require('../lib/gen-ts');
 const fixturesDir = path.join(__dirname, '..', 'src', 'test', 'fixtures');
 const goldensDir = path.join(__dirname, '..', 'src', 'test', 'goldens');
 
-fsExtra.emptyDir(goldensDir);
+fsExtra.emptyDirSync(goldensDir);
 
 for (const fixture of fs.readdirSync(fixturesDir)) {
   console.log('making goldens for ' + fixture);

scripts/make-goldens.js

@@ -18,11 +18,11 @@
 set -e
 
 cd src/test
-rm -rf fixtures
-mkdir fixtures
+mkdir -p fixtures
 cd fixtures
 
 while read -r repo tag dir; do
+  if [ -d $dir ]; then continue; fi  # Already set up.
   git clone $repo $dir
   cd $dir
   git checkout $tag

scripts/setup-fixtures.sh

@@ -0,0 +1,34 @@
+class MyClass {
+  no_params() { }
+
+  one_param(p1) { }
+
+  two_params(p1, p2) { }
+
+  /**
+   * @return {boolean}
+   */
+  typed_return() { }
+
+  /**
+   * @param {string} p1
+   * @param {number} p2
+   * @return {boolean}
+   */
+  two_typed_params_and_typed_return(p1, p2) { }
+
+  /**
+   * @param {...string} p1
+   */
+  typed_rest_param(...p1) { }
+
+  /**
+   * @param {string=} p1
+   */
+  optional_param(p1) { }
+
+  /**
+   * @param {string=} p2
+   */
+  required_and_optional_param(p1, p2) { }
+}

src/test/fixtures/custom/my-class.js

@@ -0,0 +1,10 @@
+declare class MyClass {
+  no_params(): any;
+  one_param(p1: any): any;
+  two_params(p1: any, p2: any): any;
+  typed_return(): boolean;
+  two_typed_params_and_typed_return(p1: string, p2: number): boolean;
+  typed_rest_param(...p1: string[]): any;
+  optional_param(p1?: string): any;
+  required_and_optional_param(p1: any, p2?: string): any;
+}